From: Junio C Hamano <gitster@pobox•com>
To: Benoit Pierre <benoit.pierre@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 0/6] fix hunk editing with 'commit -p -m'
Date: Thu, 06 Mar 2014 13:15:02 -0800 [thread overview]
Message-ID: <xmqqvbvrvxk8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1394117424-29780-1-git-send-email-benoit.pierre@gmail.com> (Benoit Pierre's message of "Thu, 6 Mar 2014 15:50:18 +0100")
Benoit Pierre <benoit.pierre@gmail•com> writes:
> This patch fixes the fact that hunk editing with 'commit -p -m' does not work:
> GIT_EDITOR is set to ':' to indicate to hooks that no editor will be launched,
> which result in the 'hunk edit' option not launching the editor (and selecting
> the whole hunk).
>
> The fix consists in deferring the GIT_EDITOR override to the hook subprocess,
> like it's already done for GIT_INDEX_FILE:
> - modify 'run_hook' so the first parameter is the environment to set
> - add a 'run_hook_v' variant that take a va_list
> - add a new 'run_commit_hook' helper (to set both GIT_EDITOR and GIT_INDEX_FILE)
I sense that this is in line with one of the "leftover bits" items I
keep in http://git-blame.blogspot.com/p/leftover-bits.html,
especially http://thread.gmane.org/gmane.comp.version-control.git/192669/focus=192806
;-)
prev parent reply other threads:[~2014-03-06 21:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 14:50 [PATCH 0/6] fix hunk editing with 'commit -p -m' Benoit Pierre
2014-03-06 14:50 ` [PATCH 1/6] test patch hunk editing with "commit -p -m" Benoit Pierre
2014-03-06 22:07 ` Eric Sunshine
2014-03-06 23:11 ` Junio C Hamano
2014-03-06 14:50 ` [PATCH 2/6] commit: fix " Benoit Pierre
2014-03-06 21:25 ` Junio C Hamano
2014-03-06 21:47 ` Junio C Hamano
2014-03-06 14:50 ` [PATCH 3/6] merge: fix GIT_EDITOR override for commit hook Benoit Pierre
2014-03-06 14:50 ` [PATCH 4/6] merge hook tests: fix and update tests Benoit Pierre
2014-03-06 22:11 ` Eric Sunshine
2014-03-06 14:50 ` [PATCH 5/6] merge hook tests: fix missing '&&' in test Benoit Pierre
2014-03-06 21:27 ` Junio C Hamano
2014-03-06 14:50 ` [PATCH 6/6] merge hook tests: use 'test_must_fail' instead of '!' Benoit Pierre
2014-03-06 21:29 ` Junio C Hamano
2014-03-07 0:35 ` Junio C Hamano
2014-03-06 21:15 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbvrvxk8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=benoit.pierre@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox