From: Junio C Hamano <gitster@pobox•com>
To: Keith Derrick <keith.derrick@lge•com>
Cc: "git\@vger.kernel.org" <git@vger•kernel.org>
Subject: Re: BUG: check-ref-format and rev-parse can not handle branches with an @ in their name combined with @{u}
Date: Tue, 14 Jan 2014 15:45:27 -0800 [thread overview]
Message-ID: <xmqqvbxm2kmg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <52D5C296.7050906@lge.com> (Keith Derrick's message of "Tue, 14 Jan 2014 18:04:54 -0500")
Keith Derrick <keith.derrick@lge•com> writes:
> I couldn't find a duplicate in the JIRA instance.
Don't worry, we do not use any JIRA instance ;-)
> According to the documentation of check-ref-format, a branch name such
> as @mybranch is valid.
Correct.
> Yet 'git check-ref-format --branch @mybranch@{u}'
> claims @mybranch is an invalid branch name.
I do not think it claims any such thing.
$ git check-ref-format --branch @foo@{u}; echo $?
fatal: '@foo@{u}' is not a valid branch name
128
$ git check-ref-format --branch @foo; echo $?
@foo
0
The former asks "Is the string '@foo@{u}' a suitable name to give a
branch?" and the answer is no. The latter asks the same question
about the string '@foo', and the answer is yes.
So I do not see any bug here.
next prev parent reply other threads:[~2014-01-14 23:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 23:04 BUG: check-ref-format and rev-parse can not handle branches with an @ in their name combined with @{u} Keith Derrick
2014-01-14 23:45 ` Junio C Hamano [this message]
2014-01-15 5:00 ` Jeff King
2014-01-15 7:46 ` Junio C Hamano
2014-01-15 7:47 ` Jeff King
2014-01-15 8:25 ` [PATCH 0/5] interpret_branch_name bug potpourri Jeff King
2014-01-15 8:26 ` [PATCH 1/5] interpret_branch_name: factor out upstream handling Jeff King
2014-01-15 8:27 ` [PATCH 2/5] interpret_branch_name: rename "cp" variable to "at" Jeff King
2014-01-15 8:31 ` [PATCH 3/5] interpret_branch_name: always respect "namelen" parameter Jeff King
2014-01-15 8:37 ` [PATCH 4/5] interpret_branch_name: avoid @{upstream} past colon Jeff King
2014-01-15 8:40 ` [PATCH 5/5] interpret_branch_name: find all possible @-marks Jeff King
2014-01-15 21:03 ` [PATCH 0/5] interpret_branch_name bug potpourri Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbxm2kmg.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=keith.derrick@lge$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox