public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Ted Zlatanov <tzz@lifelogs•com>
Cc: git@vger•kernel.org
Subject: Re: netrc credential helper promotion out of contrib?
Date: Tue, 20 Aug 2013 12:28:39 -0700	[thread overview]
Message-ID: <xmqqvc305fh4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <87k3jjp9q5.fsf@lifelogs.com> (Ted Zlatanov's message of "Sun, 18 Aug 2013 06:35:46 -0400")

Ted Zlatanov <tzz@lifelogs•com> writes:

> A while has passed since contrib/credential/netrc was added. Is it OK to
> promote it to be part of the main installation?

I gave it a quick glance, and it seems to be cleanly written, except
that "EOHIPPUS" (End-of-Hippus?  Eohippus the extinct horse?) looked
a bit too strange to my taste ;-).  It does not seem to use features
older versions of Perl some people are stuck with do not support.

I do not mind seeing a patch that moves contrib/credential/netrc to
credential/netrc and adjusts the top-level Makefile.  The test
script needs to be updated to fit the rest of t/ hierarchy better,
though.

  reply	other threads:[~2013-08-20 19:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-18 10:35 netrc credential helper promotion out of contrib? Ted Zlatanov
2013-08-20 19:28 ` Junio C Hamano [this message]
2013-09-03 15:12   ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvc305fh4.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=tzz@lifelogs$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox