From: Junio C Hamano <gitster@pobox•com>
To: Patrick Steinhardt <ps@pks•im>
Cc: Jeff King <peff@peff•net>, git@vger•kernel.org
Subject: Re: [PATCH 0/5] refs: remove functions without ref store
Date: Tue, 07 May 2024 08:46:53 -0700 [thread overview]
Message-ID: <xmqqwmo5sjyq.fsf@gitster.g> (raw)
In-Reply-To: <ZjnKfllMW9rGgWPL@tanuki> (Patrick Steinhardt's message of "Tue, 7 May 2024 08:30:22 +0200")
Patrick Steinhardt <ps@pks•im> writes:
>> What I had in mind was a lot more stupid like the attached. For
>> illustration purposes, I just did only one, but you got the idea.
>> Thanks to "#if 0", the compilation will fail, the compiler telling
>> the developer "resolve_ref_unsafe()? what are you talking about?",
>> and the developer will grep for that name to find the hint at the
>> end.
>
> That works for me, too. Thanks!
And if I replace 0 with USE_IMPLICIT_MAIN_REFSTORE (which is never
defined anywhere, and only serves for documentation purposes with
its rather explicit name), you get an exact implementation of what I
meant by "an approach similar to USE_THE_INDEX_MACROS".
Having said all that, as I expect that the topic itself will go
through smoothly down to 'master' (once a topic hits 'next', unless
it still has dubious parts, it usually takes 7 calendar days before
it goes to 'master') because the other parts of the series are fairly
straight-forward, we do not need anything more than just removing them,
without the helpful documentation in this case, especially given that
the adjustment other people need to do is very mechanical (and the
recipe is already in the coccinelle step). They can notice that
their new call to resolve_ref_unsafe() does not compile, grep for
resolve_ref_unsafe and find nothing, and then they'll know to use
"log -Sresolve_ref_unsafe" to find what series removed it, what
happened to its old callers, and then adjust their calls.
Thanks.
next prev parent reply other threads:[~2024-05-07 15:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 6:27 [PATCH 0/5] refs: remove functions without ref store Patrick Steinhardt
2024-05-03 6:27 ` [PATCH 1/5] refs: introduce missing functions that accept a `struct ref_store` Patrick Steinhardt
2024-05-03 17:11 ` Junio C Hamano
2024-05-03 6:28 ` [PATCH 2/5] refs: add `exclude_patterns` parameter to `for_each_fullref_in()` Patrick Steinhardt
2024-05-03 18:44 ` Taylor Blau
2024-05-03 6:28 ` [PATCH 3/5] cocci: introduce rules to transform "refs" to pass ref store Patrick Steinhardt
2024-05-03 6:28 ` [PATCH 4/5] cocci: apply rules to rewrite callers of "refs" interfaces Patrick Steinhardt
2024-05-03 18:48 ` Taylor Blau
2024-05-03 19:20 ` Junio C Hamano
2024-05-06 6:35 ` Patrick Steinhardt
2024-05-03 6:28 ` [PATCH 5/5] refs: remove functions without ref store Patrick Steinhardt
2024-05-06 1:15 ` James Liu
2024-05-03 17:24 ` [PATCH 0/5] " Junio C Hamano
2024-05-03 17:35 ` Jeff King
2024-05-03 18:24 ` Junio C Hamano
2024-05-06 6:44 ` Patrick Steinhardt
2024-05-06 16:14 ` Junio C Hamano
2024-05-07 5:56 ` Patrick Steinhardt
2024-05-07 6:20 ` Junio C Hamano
2024-05-07 6:30 ` Patrick Steinhardt
2024-05-07 15:46 ` Junio C Hamano [this message]
2024-05-09 16:55 ` Jeff King
2024-05-10 5:54 ` Patrick Steinhardt
2024-05-03 18:58 ` Taylor Blau
2024-05-03 19:35 ` Junio C Hamano
2024-05-07 7:11 ` [PATCH v2 " Patrick Steinhardt
2024-05-07 7:11 ` [PATCH v2 1/5] refs: introduce missing functions that accept a `struct ref_store` Patrick Steinhardt
2024-05-07 7:11 ` [PATCH v2 2/5] refs: add `exclude_patterns` parameter to `for_each_fullref_in()` Patrick Steinhardt
2024-05-07 7:11 ` [PATCH v2 3/5] cocci: introduce rules to transform "refs" to pass ref store Patrick Steinhardt
2024-05-07 7:11 ` [PATCH v2 4/5] cocci: apply rules to rewrite callers of "refs" interfaces Patrick Steinhardt
2024-05-07 7:11 ` [PATCH v2 5/5] refs: remove functions without ref store Patrick Steinhardt
2024-05-07 17:27 ` [PATCH v2 0/5] " Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmo5sjyq.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox