From: Junio C Hamano <gitster@pobox•com>
To: Dragan Simic <dsimic@manjaro•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 0/5] New config option for git-grep to include untracked files
Date: Mon, 18 Mar 2024 17:21:51 -0700 [thread overview]
Message-ID: <xmqqwmpzt6jk.fsf@gitster.g> (raw)
In-Reply-To: <cover.1710781235.git.dsimic@manjaro.org> (Dragan Simic's message of "Mon, 18 Mar 2024 18:03:20 +0100")
Dragan Simic <dsimic@manjaro•org> writes:
> This patch series introduces new config option grep.includeUntracked,
> which makes the untracked files also searched by default when git-grep(1)
> is invoked, in addition to searching the tracked files.
Hmph. I am moderately negative on any configuration that screws
with the default haystack from which needle is sought for.
I may often do "git grep --cached" but that does not mean I would
welcome an configuration option to make "git grep" search in the
index even when the request by the user does not have "--cached".
Inclusion of untracked sources in a sense is even worse, especially
when an unsuspecting "git grep" user (or a script) fully expects
that any paths found in the output are to be found in "git ls-files
-s" output but when you stray into a repository with the
configuration set, that expectation suddelnly gets broken.
So, I dunno.
next prev parent reply other threads:[~2024-03-19 0:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 17:03 [PATCH 0/5] New config option for git-grep to include untracked files Dragan Simic
2024-03-18 17:03 ` [PATCH 1/5] grep: perform some minor code and comment cleanups Dragan Simic
2024-03-18 19:59 ` Eric Sunshine
2024-03-18 22:03 ` Dragan Simic
2024-03-19 0:32 ` Junio C Hamano
2024-03-19 5:33 ` Dragan Simic
2024-03-18 17:03 ` [PATCH 2/5] grep docs: describe --recurse-submodules further and improve formatting a bit Dragan Simic
2024-03-18 20:02 ` Eric Sunshine
2024-03-18 22:14 ` Dragan Simic
2024-03-18 17:03 ` [PATCH 3/5] grep docs: describe --no-index further Dragan Simic
2024-03-19 0:55 ` Junio C Hamano
2024-03-19 5:37 ` Dragan Simic
2024-03-18 17:03 ` [PATCH 4/5] grep: introduce new config option to include untracked files Dragan Simic
2024-03-19 0:58 ` Junio C Hamano
2024-03-19 5:47 ` Dragan Simic
2024-03-19 14:32 ` Junio C Hamano
2024-03-19 14:52 ` Dragan Simic
2024-03-18 17:03 ` [PATCH 5/5] grep docs: describe " Dragan Simic
2024-03-19 0:21 ` Junio C Hamano [this message]
2024-03-19 5:09 ` [PATCH 0/5] New config option for git-grep " Dragan Simic
2024-03-19 17:43 ` Junio C Hamano
2024-03-19 17:48 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmpzt6jk.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=dsimic@manjaro$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox