Subject: Re: [PATCH 3/3] advice: allow disabling the automatic hint in advise_if_enabled()

From: Junio C Hamano <[email-masked]>
Date: Thu, 18 Jan 2024 12:19:29 -0800

Dragan Simic <[email-masked]> writes:

> On 2024-01-18 19:26, Junio C Hamano wrote:
>> Dragan Simic <[email-masked]> writes:
>> 
>>> Perhaps having both options available could be a good thing.  Though,
>>> adding quite a few knobs may end up confusing the users, so we should
>>> make sure to document it well.
>> I agree there is a need for documentation, but we are not increasing
>> the number of knobs, are we?
>
> Perhaps there would be one more knob if we end up deciding to implement
> support for both approaches, as previously discussed.

But that would be just one knob (which I personally do not quite see
the need for), not "quite a few knobs" as you said, no?