Subject: Re: [PATCH v2 1/5] http: drop support for curl < 7.11.1

From: Junio C Hamano <[email-masked]>
Date: Wed, 21 Jul 2021 15:56:19 -0700

Ævar Arnfjörð Bjarmason  <[email-masked]> writes:

> From: Jeff King <[email-masked]>
>
> Drop support for this ancient version of curl and simplify the code by
> allowing us get rid of some "#ifdef"'s.
>
> Git will not build with vanilla curl older than 7.11.1 due to (at
> least) two issues:
>
>   - our use of CURLOPT_POSTFIELDSIZE in 37ee680d9b
>     (http.postbuffer: allow full range of ssize_t values,
>     2017-04-11). This field was introduced in curl 7.11.1.
>
>   - our use of CURLPROTO_* outside any #ifdef in aeae4db174
>     (http: create function to get curl allowed protocols,
>     2016-12-14). These were introduced in curl 7.19.4.
>
> We could solve these compilation problems with more #ifdefs,
> but it's not worth the trouble. Version 7.11.1 came out in
> March of 2004, over 13 years ago. Let's declare that too old

13+4=17; in 2/5 you say 2006 is 15 years ago, and I think this
should be updated, too.  Is 21-4=17 close enough?

> and drop any existing ifdefs that go further back. One
> obvious benefit is that we'll have fewer conditional bits
> cluttering the code.
>
> This patch drops all #ifdefs that reference older versions
> (note that curl's preprocessor macros are in hex, so we're
> looking for 070b01, not 071101).

Yup.  I sense that we'd be dropping anything older than 7.19.4
because nobody complained about our dependency on CURLPROTO_* for
the past 5 years?