Subject: Re: [PATCH 14/15] [GSOC] cat-file: re-implement --textconv, --filters options

From: Junio C Hamano <[email-masked]>
Date: Thu, 01 Jul 2021 12:55:08 -0700

"ZheNing Hu via GitGitGadget" <[email-masked]> writes:

> +#define USE_THE_INDEX_COMPATIBILITY_MACROS
>  #include "builtin.h"
>  #include "cache.h"
>  #include "parse-options.h"
> @@ -84,6 +85,9 @@ static struct expand_data {
>  	struct object_info info;
>  } oi, oi_deref;
>  
> +int use_filters;
> +int use_textconv;

With this commit in, "make sparse" dies like so:

    SP ref-filter.c
ref-filter.c:88:5: error: symbol 'use_filters' was not declared. Should it be static?
ref-filter.c:89:5: error: symbol 'use_textconv' was not declared. Should it be static?