Subject: Re: [PATCH 01/16] check-non-portable-shell: complain about "test" a/-o instead of &&/||

From: Junio C Hamano <[email-masked]>
Date: Mon, 12 Apr 2021 11:36:37 -0700

Matthieu Moy <[email-masked]> writes:

> And also in Git's Documentation/CodingGuidelines, which motivates the advice with an example:
>
>      test -n "$x" -a "$a" = "$b"
>
>    is buggy and breaks when $x is "=", but
>
>      test -n "$x" && test "$a" = "$b"
>
>    does not have such a problem.

Good advice to cite Documentation/CodingGuidelines in the log
message.

Thanks (and nice to hear from you again ;-).