public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>,
	"Stefan Beller" <sbeller@google•com>, "Jeff King" <peff@peff•net>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
	"David Turner" <novalis@novalis•org>,
	"Brandon Williams" <bmwill@google•com>,
	"Johannes Sixt" <j6t@kdbg•org>, "Øyvind Holm" <sunny@sunbase•org>,
	"Linus Torvalds" <torvalds@linux-foundation•org>,
	git@vger•kernel.org
Subject: Re: [PATCH 1/2] for_each_bisect_ref(): don't trim refnames
Date: Thu, 15 Jun 2017 15:26:44 -0700	[thread overview]
Message-ID: <xmqqwp8cyjiz.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <3615deefe90bebe746618b04c055a466a442f85b.1497430232.git.mhagger@alum.mit.edu> (Michael Haggerty's message of "Wed, 14 Jun 2017 11:07:26 +0200")

Michael Haggerty <mhagger@alum•mit.edu> writes:

> `for_each_bisect_ref()` is called by `for_each_bad_bisect_ref()` with
> a term "bad". This used to make it call `for_each_ref_in_submodule()`
> with a prefix "refs/bisect/bad". But the latter is the name of the
> reference that is being sought, so the empty string was being passed
> to the callback as the trimmed refname. Moreover, this questionable
> practice was turned into an error by
>
>     b9c8e7f2fb prefix_ref_iterator: don't trim too much, 2017-05-22
>
> It makes more sense (and agrees better with the documentation of
> `--bisect`) for the callers to receive the full reference names. So
>
> * Add a new function, `for_each_fullref_in_submodule()`, to the refs
>   API.
>
> * Change `for_each_bad_bisect_ref()` to call the new function rather
>   than `for_each_ref_in_submodule()`.

This unfortunately makes nd/prune-in-worktree topic rather
obsolete.  Can somebody volunteer to update it to newer codebase
including this fix?

Thanks.

next prev parent reply	other threads:[~2017-06-15 22:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14  0:06 [BUG] b9c8e7f2fb6e breaks git bisect visualize Øyvind A. Holm
2017-06-14  8:36 ` Michael Haggerty
2017-06-14  9:07   ` [PATCH 0/2] Fix a refname trimming problem in `log --bisect` Michael Haggerty
2017-06-14  9:07     ` [PATCH 1/2] for_each_bisect_ref(): don't trim refnames Michael Haggerty
2017-06-14  9:22       ` Jeff King
2017-06-14  9:32         ` Jeff King
2017-06-14 10:05           ` Junio C Hamano
2017-06-15 22:26       ` Junio C Hamano [this message]
2017-06-14  9:07     ` [PATCH 2/2] prefix_ref_iterator_advance(): relax the check of trim length Michael Haggerty
2017-06-14  9:24     ` [PATCH 0/2] Fix a refname trimming problem in `log --bisect` Jeff King
2017-06-14 10:09     ` Junio C Hamano
2017-06-14  9:18   ` [BUG] b9c8e7f2fb6e breaks git bisect visualize Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwp8cyjiz.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=avarab@gmail$(echo .)com \
    --cc=bmwill@google$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=j6t@kdbg$(echo .)org \
    --cc=mhagger@alum$(echo .)mit.edu \
    --cc=novalis@novalis$(echo .)org \
    --cc=pclouds@gmail$(echo .)com \
    --cc=peff@peff$(echo .)net \
    --cc=sbeller@google$(echo .)com \
    --cc=sunny@sunbase$(echo .)org \
    --cc=torvalds@linux-foundation$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox