From: Junio C Hamano <gitster@pobox•com>
To: Vladimir Panteleev <thecybershadow@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] show-ref: Allow --head to work with --verify
Date: Fri, 20 Jan 2017 15:15:35 -0800 [thread overview]
Message-ID: <xmqqwpdpuxuw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqefzxwew9.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Fri, 20 Jan 2017 14:22:14 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> Your log message for the patch needs to be updated by summarizing
> the above better.
Here is my attempt.
"git show-ref HEAD" used with "--verify" (because the user is
not interested in seeing refs/remotes/origin/HEAD), and used
with "--head" (because the user does not want HEAD to be
filtered out), i.e. "git show-ref --head --verify HEAD", did
not work as expected.
Instead of insisting that the input begins with "refs/", allow
"HEAD" when "--head" is given in the codepath that handles
"--verify", so that all valid full refnames including HEAD are
passed to the same output machinery.
next prev parent reply other threads:[~2017-01-20 23:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 15:50 [PATCH] show-ref: Allow --head to work with --verify Vladimir Panteleev
2017-01-20 19:03 ` Junio C Hamano
2017-01-20 20:26 ` Vladimir Panteleev
2017-01-20 20:51 ` Vladimir Panteleev
2017-01-20 22:22 ` Junio C Hamano
2017-01-20 22:31 ` Junio C Hamano
2017-01-20 23:15 ` Junio C Hamano [this message]
2017-01-20 22:55 ` Vladimir Panteleev
2017-01-20 23:20 ` Junio C Hamano
2017-01-20 23:29 ` Junio C Hamano
2017-01-21 0:25 ` Vladimir Panteleev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpdpuxuw.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=thecybershadow@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox