From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: git@vger•kernel.org, Jeff King <peff@peff•net>
Subject: Re: What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken
Date: Thu, 02 Jun 2016 14:31:50 -0700 [thread overview]
Message-ID: <xmqqwpm7s2ex.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqq1t4ftheu.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Thu, 02 Jun 2016 14:22:33 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> Torsten Bögershausen <tboegi@web•de> writes:
>
>> It seams as ./t1308-config-set.sh is broken,
>> when the the directory is a soft link:
>>
>> -name=/home/tb/NoBackup/projects/git/git.pu/t/trash
>> directory.t1308-config-set/.gitconfig
>> +name=/home/tb/projects/git/git.pu/t/trash directory.t1308-config-set/.gitconfig
>> scope=global
>
> It does seem that way. Somebody is affected by $PWD when we should
> be consistently using the physical / real path.
>
>>
>> key=foo.bar
>> not ok 28 - iteration shows correct origins
>>
>> I havent't digged further, too many conflicts in the config code, may be
>> somebody knows it directly ?
Perhaps like this, taking hint from the log message of 6eafa6d0
(submodules: don't stumble over symbolic links when cloning
recursively, 2012-07-12)?
t/t1308-config-set.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
index 065d5eb..1ba9ecb 100755
--- a/t/t1308-config-set.sh
+++ b/t/t1308-config-set.sh
@@ -237,7 +237,7 @@ test_expect_success 'iteration shows correct origins' '
key=foo.bar
value=from-home
origin=file
- name=$(pwd)/.gitconfig
+ name=$TRASH_DIRECTORY/.gitconfig
scope=global
key=foo.bar
next prev parent reply other threads:[~2016-06-02 21:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 22:15 What's cooking in git.git (May 2016, #09; Tue, 31) Junio C Hamano
2016-06-02 14:01 ` What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken Torsten Bögershausen
2016-06-02 21:22 ` Junio C Hamano
2016-06-02 21:31 ` Junio C Hamano [this message]
2016-06-02 21:39 ` Jeff King
2016-06-02 22:15 ` [PATCH] t1308: do not get fooled by symbolic links to the source tree Junio C Hamano
2016-06-02 23:16 ` Jeff King
2016-06-02 23:23 ` Stefan Beller
2016-06-03 1:07 ` Jeff King
2016-06-03 6:05 ` Johannes Sixt
2016-06-03 6:10 ` Jeff King
2016-06-03 6:53 ` Johannes Sixt
2016-06-03 9:19 ` Torsten Bögershausen
2016-07-14 12:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpm7s2ex.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox