From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Dan Aloni <alonid@gmail•com>,
git@vger•kernel.org, Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCH v7 2/2] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed
Date: Fri, 05 Feb 2016 14:20:49 -0800 [thread overview]
Message-ID: <xmqqwpqibxz2.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160205214832.GA10052@sigill.intra.peff.net> (Jeff King's message of "Fri, 5 Feb 2016 16:48:33 -0500")
Jeff King <peff@peff•net> writes:
> This is sort-of about "commit", which would put it in the t75xx range.
> But in some ways, it is even more fundamental than that. We don't seem
> to have a lot of tests for ident stuff. The closest is the strict ident
> stuff in t0007.
Good point.
>> +reprepare () {
>> + git reset --hard initial
>> +}
>
> Do we need this reprepare stuff at all now? The tests don't care which
> commit we're at when they start.
Ah, I thought the function was needed to make sure we have something
to commit, but I agree that you do not need it, if you are going to
use "commit --allow-empty" in the tests.
> So all together, maybe:
Sounds sensible.
Thanks.
next prev parent reply other threads:[~2016-02-05 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 21:29 [PATCH v7] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed Dan Aloni
2016-02-05 21:29 ` [PATCH v7 1/2] fmt_ident: refactor strictness checks Dan Aloni
2016-02-05 21:29 ` [PATCH v7 2/2] ident: add user.useConfigOnly boolean for when ident shouldn't be guessed Dan Aloni
2016-02-05 21:48 ` Jeff King
2016-02-05 22:03 ` Dan Aloni
2016-02-05 22:20 ` Junio C Hamano [this message]
2016-02-05 21:59 ` Eric Sunshine
2016-02-05 22:18 ` Dan Aloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpqibxz2.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=alonid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox