Subject: Re: [PATCH v3] gitk: Add a "Copy commit summary" command

From: Junio C Hamano <[email-masked]>
Date: Fri, 17 Jul 2015 10:28:07 -0700

Eric Sunshine <[email-masked]> writes:

>> Signed-off-by: Beat Bolli <[email-masked]>
>> Reviewed-by: Eric Sunshine <[email-masked]>
>> Reviewed-by: Johannes Sixt <[email-masked]>
>
> You should drop these Reviewed-by: footers, as they imply that the
> code was thoroughly digested and the implementation deemed correct.

... and the most importantly, the named people said that themselves.

I do not think that happened here (yet).

>> +proc copysummary {} {
>> +    global rowmenuid
>> +
>> +    set format "%h (\"%s\", %ad)"
>> +    set summary [exec git show -s --pretty=format:$format --date=short \
>> +                 $rowmenuid]
>> +
>> +    clipboard clear
>> +    clipboard append $summary
>> +}
>> +

I think this is a reasonable implementation.  The usual "spawning a
process for each commit is too expensive" would not apply, because
it is done on demand only for the single commit that the end-user
specified.