From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr>,
git@vger•kernel.org,
remi lespinet <remi.lespinet@ensimag•grenoble-inp.fr>,
louis--alexandre stuber
<louis--alexandre.stuber@ensimag•grenoble-inp.fr>,
remi galan-alfonso <remi.galan-alfonso@ensimag•grenoble-inp.fr>,
guillaume pages <guillaume.pages@ensimag•grenoble-inp.fr>,
chriscool@tuxfamily•org, thomasxnguy@gmail•com,
valentinduperray@gmail•com
Subject: Re: [PATCH 4/4] bisect: add the terms old/new
Date: Wed, 10 Jun 2015 08:24:48 -0700 [thread overview]
Message-ID: <xmqqwpzbmvr3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpq7frcast5.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 10 Jun 2015 10:09:10 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
> "Somebody else did it like that" is not a good justification. Especially
> when the previous code was not merged: the code wasn't finished.
>
> But I actually disagree with the fact that it was not the idea. The
> point of having the terms in BISECT_TERMS was precisely to be generic
> enough. Had the goal been just to distinguish good/bad and old/new, we
> would have needed only one bit of information, and encoding it with the
> existance/non-existance of a file would have been sufficient (as you
> tried to do in addition to BISECT_TERMS).
>
>> For now we just rebased, corrected and finishing to implement
>> functionalities.
>
> functionalities is one thing, but the code should be maintainable to be
> merged in git.git. Git would not be where it is if Junio was merging
> patches based on "it works, we'll see if the code is good enough later"
> kinds of judgments ;-).
>
> Moving from "one hardcoded pair of terms" to "two hardcoded pairs of
> terms" is a nice feature, but hardly a step in the right direction wrt
> maintainability.
Nicely put. From that point of view, the variable names and the
underlying machinery in general should call these two "new" vs
"old". I.e. name_new=bad name_old=good would be the default, not
name_bad=bad name_good=good.
next prev parent reply other threads:[~2015-06-10 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <78277223.323387.1433874176840.JavaMail.zimbra@ensimag.grenoble-inp.fr>
2015-06-10 7:11 ` [PATCH 4/4] bisect: add the terms old/new Antoine Delaite
2015-06-10 8:09 ` Matthieu Moy
2015-06-10 15:24 ` Junio C Hamano [this message]
2015-06-10 15:47 ` Christian Couder
2015-06-10 16:08 ` Junio C Hamano
2015-06-08 20:22 [PATCH 1/4] bisect : correction of typo Antoine Delaite
2015-06-08 20:22 ` [PATCH 4/4] bisect: add the terms old/new Antoine Delaite
2015-06-08 21:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpzbmvr3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=guillaume.pages@ensimag$(echo .)grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.lespinet@ensimag$(echo .)grenoble-inp.fr \
--cc=thomasxnguy@gmail$(echo .)com \
--cc=valentinduperray@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox