From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: "Sébastien Guimmara" <sebastien.guimmara@gmail•com>,
"Git List" <git@vger•kernel.org>
Subject: Re: [PATCH v11 2/5] command-list.txt: add the common groups block
Date: Tue, 26 May 2015 12:13:27 -0700 [thread overview]
Message-ID: <xmqqwpzvjgo8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cRPE30=euNYMEek4h8WgfMVFZKgxTqD8=L6BE11FAs8YA@mail.gmail.com> (Eric Sunshine's message of "Tue, 26 May 2015 14:31:17 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
>>>> +history grow, mark and tweak your common history
>>>> +remote collaborate (see also: git help workflows)
>>>> +
>>>> +# List of known git commands.
>>>
>>> This is odd. The above line was removed in 1/5 but then re-appears
>>> here in 2/5. I think the intent is that it should remain removed.
>>>
>>>> ### command list (do not change this line)
>>>> # command name category [deprecated] [common]
>>>> git-add mainporcelain common
>>
>> My mistake. This will be corrected in the next version. Thank you for taking
>> time to review this series.
>
> Junio already made these corrections locally when he picked up the
> series. Take a look at his 'pu' branch, and you'll find the series
> there with the corrections[1]. Thus, no need to re-send.
>
> [1]: Series currently merged into 'pu' at de905cf0.
Yeah, resurrecting "List of known git commands." does look somewhat
strange, but looking at what this step does, especially this bit:
> diff --git a/command-list.txt b/command-list.txt
> index 181a9c2..32ddab3 100644
> --- a/command-list.txt
> +++ b/command-list.txt
> @@ -1,3 +1,14 @@
> +# common commands are grouped by themes
> +# these groups are output by 'git help' in the order declared here.
> +# map each common command in the command list to one of these groups.
> +### common groups (do not change this line)
> +init start a working area (see also: git help tutorial)
> +worktree work on the current change (see also: git help everyday)
I do not think we would terribly mind an introductory comment that
applies to the next "###" block before it, e.g.
# list of known git commands; ordered alphabetically
# for easy spotting
### command list (do not change this line)
For some reason the patch seems to want to spell that comment in all
lowercase, so I just imitated it here.
In any case, if somebody wants to add such a comment there for
symmetry, that can be done as a follow-up patch after dust from
these patches settles, I think. Let's have these 5 patches graduate
to 'next' without further bikeshedding ;-)
next prev parent reply other threads:[~2015-05-26 19:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 17:39 [PATCH v11 0/5] group common commands by theme Sébastien Guimmara
2015-05-21 17:39 ` [PATCH v11 1/5] command-list: prepare machinery for upcoming "common groups" section Sébastien Guimmara
2015-05-21 17:39 ` [PATCH v11 2/5] command-list.txt: add the common groups block Sébastien Guimmara
2015-05-21 18:01 ` Eric Sunshine
2015-05-25 17:31 ` Sébastien Guimmara
2015-05-26 18:31 ` Eric Sunshine
2015-05-26 19:13 ` Junio C Hamano [this message]
2015-05-21 17:39 ` [PATCH v11 3/5] generate-cmdlist: parse common group commands Sébastien Guimmara
2015-05-21 17:39 ` [PATCH v11 4/5] command-list.txt: drop the "common" tag Sébastien Guimmara
2015-05-21 17:39 ` [PATCH v11 5/5] help: respect new common command grouping Sébastien Guimmara
2015-05-21 18:04 ` Eric Sunshine
2015-05-25 17:25 ` Sébastien Guimmara
2015-05-21 18:15 ` [PATCH v11 0/5] group common commands by theme Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpzvjgo8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sebastien.guimmara@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox