From: Junio C Hamano <gitster@pobox•com>
To: Allen Hubbe <allenbh@gmail•com>
Cc: git@vger•kernel.org, Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format
Date: Mon, 25 May 2015 19:55:43 -0700 [thread overview]
Message-ID: <xmqqwpzw82ts.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAJ80sauoB-quepDf2V=-WqewzJ_nN+ALA-z-vcL_4c8rObxpBg@mail.gmail.com> (Allen Hubbe's message of "Mon, 25 May 2015 22:16:36 -0400")
Allen Hubbe <allenbh@gmail•com> writes:
>> Could you fetch from me and then run:
>>
>> $ git log --reverse -3 -p 6b733ee4ba330e1187017895b8426dd9171c33b8
>>
>> to see if you agree with the result? That is what I queued on 'pu'
>> for now with my fixups.
>
> It looks good to me. How would you like me to proceed? I assume you
> would like your patch on top of mine will stay, to use HOME instead of
> tilde. Or, would you like me to use HOME in my v6, too?
>
> Should I send you v6 like v5, but with the documentation fixed, or
> would you now prefer a separate patch on top of that to fix the
> documentation?
It probably should be two patches. Your sendmail thing with docs
and tests as one patch (with $HOME in test), and fix to mailrc tests
I did (minus the part that fixes your sendmail test, which should
now become unnecessary) on top.
If the documentation I queued on 'pu' formats well already (which I
cannot check myself until tomorrow), then I'd guess the above would
be like squashing 8b8fb5a into dc6183c and then 6b733ee on top, I
think.
6b733ee t9001: write $HOME/, not ~/, to help shells without tilde expansion
8b8fb5a git-send-email doc: refer to upstream document for alias format
dc6183c send-email: add sendmail email aliases format
next prev parent reply other threads:[~2015-05-26 2:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 13:21 [PATCH v5 1/1] send-email: Add sendmail email aliases format Allen Hubbe
2015-05-23 17:45 ` Junio C Hamano
2015-05-23 18:00 ` Junio C Hamano
2015-05-23 23:01 ` Allen Hubbe
2015-05-23 18:07 ` Junio C Hamano
2015-05-23 22:24 ` Allen Hubbe
2015-05-25 12:47 ` Allen Hubbe
2015-05-25 16:32 ` Junio C Hamano
2015-05-25 21:12 ` Junio C Hamano
2015-05-25 21:35 ` Junio C Hamano
2015-05-26 1:51 ` Allen Hubbe
2015-05-26 1:58 ` Junio C Hamano
2015-05-26 2:16 ` Allen Hubbe
2015-05-26 2:55 ` Junio C Hamano [this message]
2015-05-26 3:34 ` Junio C Hamano
2015-05-26 18:47 ` Eric Sunshine
2015-05-26 19:10 ` Eric Sunshine
2015-05-26 19:41 ` Allen Hubbe
2015-05-26 20:53 ` Eric Sunshine
2015-05-26 21:04 ` Allen Hubbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpzw82ts.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=allenbh@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox