From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Luke Mewburn <luke@mewburn•net>, git@vger•kernel.org
Subject: Re: [PATCH] progress: no progress in background
Date: Tue, 19 May 2015 09:12:29 -0700 [thread overview]
Message-ID: <xmqqwq048s2a.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150519051752.GA16173@peff.net> (Jeff King's message of "Tue, 19 May 2015 01:17:53 -0400")
Jeff King <peff@peff•net> writes:
>> +static int is_foreground_fd(int fd)
>> +{
>> + return getpgid(0) == tcgetpgrp(fd);
>> +}
>
> I've noticed that this patch causes a regression when we are
> transmitting progress over the sideband channel of the git protocol.
Yeah, thanks. The other day when an unrelated progress issues came,
I realized that this patch has that breakage (and immediately forgot
about it ;-).
> ... Whatever the reason, it probably makes sense to err on the
> side of printing the progress.
Yup. Thanks.
prev parent reply other threads:[~2015-05-19 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 9:34 [PATCH] progress: no progress in background Luke Mewburn
2015-05-19 5:17 ` Jeff King
2015-05-19 5:24 ` [PATCH] progress: treat "no terminal" as being in the foreground Jeff King
2015-05-19 16:12 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwq048s2a.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=luke@mewburn$(echo .)net \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox