From: Junio C Hamano <gitster@pobox•com>
To: Luke Diamand <luke@diamand•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Correction to git-p4 "exclude" change
Date: Wed, 28 Jan 2015 12:49:54 -0800 [thread overview]
Message-ID: <xmqqwq46fx59.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1422425284-5282-1-git-send-email-luke@diamand.org> (Luke Diamand's message of "Wed, 28 Jan 2015 06:08:03 +0000")
Luke Diamand <luke@diamand•org> writes:
> My previous change for adding support for "exclude" to git-p4 "sync"
> was incorrect, missing out a comma, which stopped git-p4 from working.
> This change fixes that.
>
> I've also noticed that t9814-git-p4-rename.sh has stopped working; I'm
> going to follow up with a fix for that once I've worked out what's
> wrong with it. There's a small shell syntax problem (missing "esac")
> but after fixing that it still fails, so I'm not sure what's happening
> yet. It was discussed a while back.
>
> Luke Diamand (1):
> git-p4: correct "exclude" change
>
> git-p4.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks.
Will keep out of 'master' for now. It may not be a bad idea to
squash this fix (and any futher ones if needed) into a single patch
when we rewind 'next' after 2.3 final is tagged.
next prev parent reply other threads:[~2015-01-28 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 6:08 [PATCH] Correction to git-p4 "exclude" change Luke Diamand
2015-01-28 6:08 ` [PATCH] git-p4: correct " Luke Diamand
2015-01-28 20:49 ` Junio C Hamano [this message]
[not found] ` <CAE5ih7_TJOQ=ttw03V3J9A=jtwUD-Emy-mSp0kNrYKkqMs30ng@mail.gmail.com>
2015-02-05 8:24 ` [PATCH] Correction to git-p4 " Luke Diamand
2015-02-05 19:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwq46fx59.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=luke@diamand$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox