From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Johannes Schindelin <johannes.schindelin@gmx•de>,
Stefan Beller <sbeller@google•com>,
Michael Blume <blume.mike@gmail•com>,
peter@lekensteyn•nl, eungjun.yi@navercorp•com,
Git List <git@vger•kernel.org>
Subject: Re: Git compile warnings (under mac/clang)
Date: Fri, 23 Jan 2015 10:07:18 -0800 [thread overview]
Message-ID: <xmqqwq4dqskp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150123133033.GA27692@peff.net> (Jeff King's message of "Fri, 23 Jan 2015 08:30:34 -0500")
Jeff King <peff@peff•net> writes:
>> diff --git a/fsck.c b/fsck.c
>> index 15cb8bd..8f8c82f 100644
>> --- a/fsck.c
>> +++ b/fsck.c
>> @@ -107,7 +107,7 @@ static int fsck_msg_severity(enum fsck_msg_id msg_id,
>> {
>> int severity;
>>
>> - if (options->msg_severity && msg_id >= 0 && msg_id < FSCK_MSG_MAX)
>> + if (options->msg_severity && ((unsigned int) msg_id) < FSCK_MSG_MAX)
>> severity = options->msg_severity[msg_id];
>> else {
>> severity = msg_id_info[msg_id].severity;
>> -- snap --
>>
>> What do you think? Michael, does this cause more Clang warnings,
>> or would it resolve the issue?
>
> Hmm, yeah, that does not seem unreasonable, and is more localized.
Or we could force enum to be signed by defining FSCK_MSG_UNUSED to
be -1 at the very beginning of enum definition, without changing
anything else. Then "msg_id < 0" would become a very valid
protection against programming mistakes, no?
next prev parent reply other threads:[~2015-01-23 18:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 19:43 Git compile warnings (under mac/clang) Michael Blume
2015-01-22 19:59 ` Stefan Beller
2015-01-22 21:19 ` Peter Wu
2015-01-22 21:20 ` Johannes Schindelin
2015-01-22 22:01 ` Jeff King
2015-01-23 11:48 ` Johannes Schindelin
2015-01-23 12:23 ` Jeff King
2015-01-23 12:38 ` Johannes Schindelin
2015-01-23 13:30 ` Jeff King
2015-01-23 18:07 ` Junio C Hamano [this message]
2015-01-23 18:37 ` Jeff King
2015-01-23 18:46 ` Johannes Schindelin
2015-01-23 18:55 ` Jeff King
2015-01-23 19:20 ` Johannes Schindelin
2015-01-23 18:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwq4dqskp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=blume.mike@gmail$(echo .)com \
--cc=eungjun.yi@navercorp$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=peff@peff$(echo .)net \
--cc=peter@lekensteyn$(echo .)nl \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox