From: Junio C Hamano <gitster@pobox•com>
To: Alexander Kuleshov <kuleshovmail@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] init-db: remove unused #includes
Date: Wed, 14 Jan 2015 12:14:09 -0800 [thread overview]
Message-ID: <xmqqwq4p86i6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqq61c99o25.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Wed, 14 Jan 2015 11:09:38 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> Alexander Kuleshov <kuleshovmail@gmail•com> writes:
>
>> * "cache.h" - is unnecessary because it already included at "builtin.h"
>>
>> * "exec_cmd.h" - was added at a47d1813 (Allow a relative builtin template
>> directory., 15 Nov 2007). init-db used 'git_exec_path' routine from
>> "exec_cmd.h", but later it was removed at 2de9de5e (Move code interpreting
>> path relative to exec-dir to new function system_path()., 14 Jul 2008). So
>> we no need in it anymore.
>>
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail•com>
>> ---
>
> Makes sense. Thanks.
Actually, not. 2de9de5e does make it unnecessary to refer to
git_exec_path(), but in order to reference the newly introduced
system_path(), which is declared in exec_cmd.h, the file still would
have needed to include the header, so the justification for the
latter does not make sense.
And indeed, we still need exec_cmd.h in today's code.
next prev parent reply other threads:[~2015-01-14 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 17:59 [PATCH] init-db: remove unused #includes Alexander Kuleshov
2015-01-14 19:09 ` Junio C Hamano
2015-01-14 20:14 ` Junio C Hamano [this message]
2015-01-15 10:13 ` Alexander Kuleshov
2015-01-15 10:55 ` Jeff King
2015-01-15 20:36 ` Junio C Hamano
2015-01-15 22:31 ` Jeff King
2015-01-15 23:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwq4p86i6.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kuleshovmail@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox