From: Junio C Hamano <gitster@pobox•com>
To: Paolo Bonzini <bonzini@gnu•org>
Cc: git@vger•kernel.org, Paolo Bonzini <pbonzini@redhat•com>
Subject: Re: [PATCH 0/2] git-am: add --message-id/--no-message-id options
Date: Tue, 25 Nov 2014 10:33:46 -0800 [thread overview]
Message-ID: <xmqqwq6jruyd.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1416924056-29993-1-git-send-email-bonzini@gnu.org> (Paolo Bonzini's message of "Tue, 25 Nov 2014 15:00:54 +0100")
Paolo Bonzini <bonzini@gnu•org> writes:
> From: Paolo Bonzini <pbonzini@redhat•com>
>
> This series adds a --message-id option to git-mailinfo and git-am.
> git-am also gets an am.messageid configuration key to set the default,
> and a --no-message-id option to override the configuration key.
> (I'm not sure of the usefulness of a mailinfo.messageid option, so
> I left it out; this follows the example of -k instead of --scissors).
>
> This option can be useful in order to associate commit messages with
> mailing list discussions.
>
> If both --message-id and -s are specified, the Signed-off-by goes
> last. This is coming out more or less naturally out of the git-am
> implementation, but is also tested in t4150-am.sh.
Nice. So if you apply a message whose last sign-off is yourself
with both of these options, what would we see?
1. S-o-b: you and then M-id: and then another S-o-b: you?
2. M-id: and then S-o-b: you?
3. S-o-b: you and then M-id:?
I do not offhand know which one of the above possibilities to favor
more over others myself. Just asking to find out more about the
thinking behind the design.
Thanks.
>
> Paolo Bonzini (2):
> git-mailinfo: add --message-id
> git-am: add --message-id/--no-message-id
>
> Documentation/git-am.txt | 11 +++++++++++
> Documentation/git-mailinfo.txt | 5 +++++
> builtin/mailinfo.c | 22 +++++++++++++++++++++-
> git-am.sh | 21 +++++++++++++++++++--
> t/t4150-am.sh | 23 +++++++++++++++++++++++
> t/t5100-mailinfo.sh | 4 ++++
> t/t5100/info0012--message-id | 5 +++++
> t/t5100/msg0012--message-id | 8 ++++++++
> t/t5100/patch0012--message-id | 30 ++++++++++++++++++++++++++++++
> 9 files changed, 126 insertions(+), 3 deletions(-)
> create mode 100644 t/t5100/info0012--message-id
> create mode 100644 t/t5100/msg0012--message-id
> create mode 100644 t/t5100/patch0012--message-id
next prev parent reply other threads:[~2014-11-25 18:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 14:00 [PATCH 0/2] git-am: add --message-id/--no-message-id options Paolo Bonzini
2014-11-25 14:00 ` [PATCH 1/2] git-mailinfo: add --message-id Paolo Bonzini
2014-11-25 14:00 ` [PATCH 2/2] git-am: add --message-id/--no-message-id Paolo Bonzini
2014-11-25 23:34 ` Junio C Hamano
2014-11-26 7:06 ` Paolo Bonzini
2014-11-25 16:27 ` [PATCH 0/2] git-am: add --message-id/--no-message-id options Christian Couder
2014-11-25 17:01 ` Paolo Bonzini
2014-11-25 21:21 ` Christian Couder
2014-11-26 9:07 ` Paolo Bonzini
2014-11-27 0:23 ` Christian Couder
2014-11-25 18:33 ` Junio C Hamano [this message]
2014-11-25 19:16 ` Paolo Bonzini
2014-11-25 20:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwq6jruyd.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=bonzini@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=pbonzini@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox