From: Junio C Hamano <gitster@pobox•com>
To: "René Scharfe" <l.s.r@web•de>
Cc: "David A. Dalrymple \(and Bhushan G. Lodha\)" <dad-bgl@mit•edu>,
git@vger•kernel.org, peff@peff•net,
"David Dalrymple \(on zayin\)" <davidad@alum•mit.edu>
Subject: Re: [PATCH 06/10] log: --function-name pickaxe
Date: Thu, 03 Apr 2014 14:44:40 -0700 [thread overview]
Message-ID: <xmqqwqf6ozp3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <533DD1B1.3000107@web.de> ("René Scharfe"'s message of "Thu, 03 Apr 2014 23:25:05 +0200")
René Scharfe <l.s.r@web•de> writes:
> With that approach you depend on the hunk header and apparently need
> to add XDL_EMIT_MOREFUNCNAMES and XDL_EMIT_MOREHUNKHEADS to improve
> the results. This approach feels fragile.
>
> Would it perhaps be more robust to not base the implementation on diff
> and instead to scan the raw file contents?
That is an interesting idea.
Perhaps this can be implemented as a new stage in the transformation
pipeline, I wonder? There is currently no transformation that
modifies the blob contents being compared, but I do not think there
is anything fundamental that prevents one from being written. The
new "limit to this function body" transformation would perhaps sit
before the diffcore-rename and would transform all the blobs to
empty, except for the part that is the body of the function the user
is interested in.
next prev parent reply other threads:[~2014-04-03 21:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 18:50 [PATCH 00/10] [RFC] pickaxe for function names David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 01/10] .gitattributes: specify the language used David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 02/10] diffcore-pickaxe.c: refactor regex compilation David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 03/10] diffcore-pickaxe.c: Refactor pickaxe_fn signature David A. Dalrymple (and Bhushan G. Lodha)
2014-04-04 11:09 ` Jakub Narębski
2014-03-27 18:50 ` [PATCH 04/10] diff.c/diff.h: expose userdiff_funcname David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 05/10] diffcore-pickaxe.c: set up funcname pattern David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 06/10] log: --function-name pickaxe David A. Dalrymple (and Bhushan G. Lodha)
2014-04-03 21:25 ` René Scharfe
2014-04-03 21:44 ` Junio C Hamano [this message]
2014-04-04 11:15 ` Jakub Narębski
2014-04-04 18:46 ` Junio C Hamano
2014-04-28 20:04 ` Bhushan Lodha
2014-03-27 18:50 ` [PATCH 07/10] xdiff: add XDL_EMIT_MOREFUNCNAMES David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 08/10] xdiff: add XDL_EMIT_MOREHUNKHEADS David A. Dalrymple (and Bhushan G. Lodha)
2014-03-27 18:50 ` [PATCH 09/10] t4213: test --function-name option David A. Dalrymple (and Bhushan G. Lodha)
2014-03-28 7:25 ` Johannes Sixt
2014-03-28 8:21 ` Eric Sunshine
2014-03-28 11:45 ` Johannes Sixt
2014-04-04 11:21 ` Jakub Narębski
2014-03-27 18:50 ` [PATCH 10/10] Documentation: Document --function-name usage David A. Dalrymple (and Bhushan G. Lodha)
2014-03-28 0:30 ` Eric Sunshine
2014-03-27 19:03 ` [PATCH 00/10] [RFC] pickaxe for function names Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwqf6ozp3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dad-bgl@mit$(echo .)edu \
--cc=davidad@alum$(echo .)mit.edu \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox