From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Jeff King <peff@peff•net>,
git@vger•kernel.org, John Keeping <john@keeping•me.uk>,
Thomas Rast <tr@thomasrast•ch>
Subject: Re: [PATCH 0/3] t0000 cleanups
Date: Mon, 30 Dec 2013 10:30:28 -0800 [thread overview]
Message-ID: <xmqqwqimry2j.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131228222129.GE5544@google.com> (Jonathan Nieder's message of "Sat, 28 Dec 2013 14:21:29 -0800")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Jeff King wrote:
>
>> When I want to debug a failing test, I often end up doing:
>>
>> cd t
>> ./t4107-<tab> -v -i
>> cd tra<tab>
>>
>> The test names are long, so tab-completing on the trash directory is
>> very helpful. Lately I've noticed that there are a bunch of crufty trash
>> directories in my t/ directory, which makes my tab-completion more
>> annoying.
>
> Ah, and if I'd read this then I wouldn't have had to be confused at
> all. Would it work to replace the commit message with something like
> this?
The third paragraph of 1/3 sufficiently covers it, no? We could add
"It makes it less convenient to use tab completion 'cd t/tra<TAB>'
to go to the trash directory of the failed test to inspect the
situation" after "... left in the t/ directory.", though.
Once upon a time, the test-lib library would create trash
directories in the current working directory, unless we were
explicitly told to put it elsewhere via --root. As a result,
t0000 created the sub-test trash directories inside its own
trash directory.
However, we noticed that this did not cover all cases, since
we would need to respect $TEST_OUTPUT_DIRECTORY even if
--root is not given (or is relative). Commit 38b074d fixed
this to consistently use the full path.
As a result, trash directories used by t0000's sub-tests are now
created in git's original test output directory rather than in our
trash directory. Furthermore, since some of the sub-tests simulate
failures, the trash directories do not get cleaned up, and the cruft
is left in the t/ directory.
We could fix this by passing a new "--root=$TRASH_DIRECTORY"
option to the sub-test. However, we do not want the sub-tests
to write anything at all to git's directory (e.g., they
should not be writing to t/test-results, either, although
this is already handled by separate code). So the best
solution is to simply reset $TEST_OUTPUT_DIRECTORY entirely
in the sub-test, which covers this case, as well as any
future ones.
next prev parent reply other threads:[~2013-12-30 18:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 9:27 [PATCH 0/3] t0000 cleanups Jeff King
2013-12-28 9:29 ` [PATCH 1/3] t0000: set TEST_OUTPUT_DIRECTORY for sub-tests Jeff King
2013-12-28 22:13 ` Jonathan Nieder
2013-12-28 22:20 ` Jonathan Nieder
2013-12-29 7:17 ` Jeff King
2013-12-28 9:31 ` [PATCH 2/3] t0000: simplify HARNESS_ACTIVE hack Jeff King
2013-12-28 22:14 ` Jonathan Nieder
2013-12-28 9:33 ` [PATCH 3/3] t0000: drop "known breakage" test Jeff King
2013-12-28 20:51 ` Jonathan Nieder
2013-12-29 7:22 ` Jeff King
2013-12-28 22:21 ` [PATCH 0/3] t0000 cleanups Jonathan Nieder
2013-12-30 18:30 ` Junio C Hamano [this message]
2013-12-30 18:51 ` Jonathan Nieder
2013-12-30 19:24 ` Junio C Hamano
2013-12-31 10:33 ` Jeff King
2014-01-02 22:28 ` Jonathan Nieder
2014-01-02 22:41 ` Junio C Hamano
2014-01-03 1:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwqimry2j.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=john@keeping$(echo .)me.uk \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=tr@thomasrast$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox