public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Vicent Martí" <tanoku@gmail•com>
Cc: Duy Nguyen <pclouds@gmail•com>, Karsten Blees <blees@dcon•de>,
	Git Mailing List <git@vger•kernel.org>, Jeff King <peff@peff•net>
Subject: Re: What's cooking in git.git (Oct 2013, #06; Fri, 25)
Date: Mon, 28 Oct 2013 09:41:35 -0700	[thread overview]
Message-ID: <xmqqwqkxfiv4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAFFjANSnuS6_+uAd43AayojJyK-wj2wMxQ6DBD6JyN=A7xh2_A@mail.gmail.com> ("Vicent Martí"'s message of "Mon, 28 Oct 2013 17:16:02 +0100")

Vicent Martí <tanoku@gmail•com> writes:

> On Mon, Oct 28, 2013 at 4:48 PM, Junio C Hamano <gitster@pobox•com> wrote:
>>> jk/pack-bitmap adds khash.h, which from a first glance looks like yet
>>> another hash table implementation. I was just wondering if kb's new
>>> hash tables can cover the need of pack-bitmap.c too so we can remove
>>> khash.h later..
>> ...
> khash on the other hand is capable of storing the position values as
> part of the hash table itself (i.e. `int **buckets`), and saves us
> from thousands of bytes of allocations + indirection.

My "Good thinking ;-)" comment was primarily meant as "somebody
needs to at least think about the possibility and consider pros and
cons", and you thought about it already ;-).

In short, kb's hash table does not cover the need for pack-bitmap,
so we should keep two at least for now, until (and/or unless) either
side can be shown (and/or extended) to cover the need for the other
one as well.

Thanks. 

next prev parent reply	other threads:[~2013-10-28 16:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-25 23:23 What's cooking in git.git (Oct 2013, #06; Fri, 25) Junio C Hamano
2013-10-26 10:30 ` Duy Nguyen
2013-10-28 15:48   ` Junio C Hamano
2013-10-28 16:16     ` Vicent Martí
2013-10-28 16:41       ` Junio C Hamano [this message]
2013-10-28 19:45       ` Karsten Blees
2013-10-28 21:04         ` Vicent Martí
2013-10-29  9:09           ` Karsten Blees
2013-11-14 19:38             ` Karsten Blees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwqkxfiv4.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=blees@dcon$(echo .)de \
    --cc=git@vger$(echo .)kernel.org \
    --cc=pclouds@gmail$(echo .)com \
    --cc=peff@peff$(echo .)net \
    --cc=tanoku@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox