Subject: Re: [PATCH v5 3/4] bloom: replace struct bloom_key * with struct bloom_keyvec

From: Junio C Hamano <[email-masked]>
Date: Fri, 11 Jul 2025 08:06:03 -0700

Lidong Yan <[email-masked]> writes:

> Junio C Hamano <[email-masked]> write:
>> 
>> Lidong Yan <[email-masked]> writes:
>> 
>>> static void prepare_to_use_bloom_filter(struct rev_info *revs)
>>> {
>>> struct pathspec_item *pi;
>>> + struct bloom_keyvec *bloom_keyvec;
>> 
>> This new variable is no longer used, since the code to create a new
>> keyvec is in a helper function and its return value is directly
>> stored in the array of keyvecs.
>> 
>>> char *path_alloc = NULL;
>>> const char *path, *p;
>> 
>> And the "p" variable no longer is used, because the logic it used to
>> create a new keyvec is moved elsewhere.
>
> Will fix in v6, Thanks,

FWIW, what I queued have these two already removed from v5.

Thanks.