Subject: Re: [PATCH v2 4/6] t5701: add setup test to remove side-effect dependency

From: Junio C Hamano <[email-masked]>
Date: Mon, 20 Jan 2025 11:52:43 -0800

Usman Akinyemi <[email-masked]> writes:

> Yeah, that is true, I could not notice this as the next commit of the
> patch series
> was able to fix it. I will change it to "echo", with this, it will be better.

If we want to prepare ourselves against any arbitrary garbage the
builder may throw at us, using printf with _fixed_ format and feed
the potentially arbitrary garbage as its parameter to be
interpolated is the safest approach, so writing it as

    printf "agent=git/%s\n" "$(git version | cut ...)"

would signal the readers that whoever wrote it knew what they were
doing and was being extra careful.

THanks.