Subject: Re: [PATCH] [OUTREACHY] t1002: modernize outdated conditional

From: Junio C Hamano <[email-masked]>
Date: Thu, 13 Oct 2022 22:05:57 -0700

"nsengaw4c via GitGitGadget" <[email-masked]> writes:

> From: wilberforce <[email-masked]>

This name must match ...

> Tests in this script use an unusual and hard to reason about
> conditional construct
>
>     if expression; then false; else :; fi
>
> Change them to use more idiomatic construct:
>
>     ! expression
>
> Cc: Christian Couder  <[email-masked]>
> Cc: Hariom Verma <[email-masked]>
> Signed-off-by: Nsengiyumva  wilberfore <[email-masked]>

... the name you sign-off your work with.

> -     if read_tree_u_must_succeed -m -u $treeH $treeM; then false; else :; fi'
> +     ! read_tree_u_must_succeed -m -u $treeH $treeM'

OK.