From: Junio C Hamano <gitster@pobox•com>
To: Derrick Stolee <derrickstolee@github•com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH 0/2] For v2.37.0: rename fetch.credentialsInUrl to transfer.credentialsInUrl
Date: Wed, 15 Jun 2022 11:35:55 -0700 [thread overview]
Message-ID: <xmqqy1xxzsdw.fsf@gitster.g> (raw)
In-Reply-To: <e53a247d-1d12-e34c-6cc8-3813a2fa34dc@github.com> (Derrick Stolee's message of "Wed, 15 Jun 2022 09:12:25 -0400")
Derrick Stolee <derrickstolee@github•com> writes:
> This rename makes sense and is good to handle before the release.
> Thank you for updating the release notes.
>
> The expanded details in the docs are good.
Generally, transfer.$name hierarchy is there to give defaults to
fetch.$name and push.$name so that the knob can be set separately
for different directions of the transfer, but for this particular
one, I do not see a reason why we want to redact fetch requests
without redacting push requests.
One thing that worries me is that this will probably burn our early
adopters, those who are willing to help our development by running
versions based on 'next' and already have fetch.* configuration.
But the breakage this change brings on them hopefully will not be
large enough to discourage them from being guinea pigs ;-)
Thanks, all.
prev parent reply other threads:[~2022-06-15 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 10:44 [PATCH 0/2] For v2.37.0: rename fetch.credentialsInUrl to transfer.credentialsInUrl Ævar Arnfjörð Bjarmason
2022-06-15 10:44 ` [PATCH 1/2] fetch doc: note "pushurl" caveat about "credentialsInUrl", elaborate Ævar Arnfjörð Bjarmason
2022-06-26 13:15 ` René Scharfe
2022-06-15 10:44 ` [PATCH 2/2] transfer doc: move fetch.credentialsInUrl to "transfer" config namespace Ævar Arnfjörð Bjarmason
2022-06-15 13:12 ` [PATCH 0/2] For v2.37.0: rename fetch.credentialsInUrl to transfer.credentialsInUrl Derrick Stolee
2022-06-15 18:35 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy1xxzsdw.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=derrickstolee@github$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox