From: Junio C Hamano <gitster@pobox•com>
To: Philip Oakley <philipoakley@iee•email>
Cc: GitList <git@vger•kernel.org>
Subject: Re: [PATCH v2] doc: check-ignore: code-quote an exclamation mark
Date: Thu, 03 Feb 2022 11:13:27 -0800 [thread overview]
Message-ID: <xmqqy22ru5k8.fsf@gitster.g> (raw)
In-Reply-To: <20220203101643.1987-1-philipoakley@iee.email> (Philip Oakley's message of "Thu, 3 Feb 2022 10:16:43 +0000")
Philip Oakley <philipoakley@iee•email> writes:
> The plain quoted exclamation mark renders as italics in the
> Windows pdf help manual.
HTML rendered version shows <em>!</em> and depending on the
stylesheet it would become italic, too. It can be seen in the
pre-rendered versions I ship at [1].
> Fix this with back-tick quoting and surrounding double quotes
> as exemplified by the gitignore.txt guide.
This becomes "<code>!</code>" (with surrounding double-quotes) [2],
and making these two pages consistent makes sense.
> While at it, fix the surrounding double quotes for the other
> special characters usages.
This changes also sounds good, too.
Will apply. Thanks.
[References]
*1* https://github.com/gitster/git-htmldocs/blob/master/git-check-ignore.html
*2* https://github.com/gitster/git-htmldocs/blob/master/gitignore.html
>
> Signed-off-by: Philip Oakley <philipoakley@iee•email>
> ---
>
> Since V1:
> Corrected finger trouble with special character when copy-pasting.
>
> Documentation/git-check-ignore.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-check-ignore.txt b/Documentation/git-check-ignore.txt
> index 0c3924a63d..2892799e32 100644
> --- a/Documentation/git-check-ignore.txt
> +++ b/Documentation/git-check-ignore.txt
> @@ -33,7 +33,7 @@ OPTIONS
> Instead of printing the paths that are excluded, for each path
> that matches an exclude pattern, print the exclude pattern
> together with the path. (Matching an exclude pattern usually
> - means the path is excluded, but if the pattern begins with '!'
> + means the path is excluded, but if the pattern begins with "`!`"
> then it is a negated pattern and matching it means the path is
> NOT excluded.)
> +
> @@ -77,7 +77,7 @@ If `--verbose` is specified, the output is a series of lines of the form:
> <pathname> is the path of a file being queried, <pattern> is the
> matching pattern, <source> is the pattern's source file, and <linenum>
> is the line number of the pattern within that source. If the pattern
> -contained a `!` prefix or `/` suffix, it will be preserved in the
> +contained a "`!`" prefix or "`/`" suffix, it will be preserved in the
> output. <source> will be an absolute path when referring to the file
> configured by `core.excludesFile`, or relative to the repository root
> when referring to `.git/info/exclude` or a per-directory exclude file.
next prev parent reply other threads:[~2022-02-03 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 10:16 [PATCH v2] doc: check-ignore: code-quote an exclamation mark Philip Oakley
2022-02-03 19:13 ` Junio C Hamano [this message]
2022-02-03 22:37 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy22ru5k8.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=philipoakley@iee$(echo .)email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox