Subject: Re: [PATCH v2 1/6] refs: open-code deletion of packed refs

From: Junio C Hamano <[email-masked]>
Date: Wed, 12 Jan 2022 16:24:36 -0800

Patrick Steinhardt <[email-masked]> writes:

> diff --git a/refs/packed-backend.h b/refs/packed-backend.h
> index f61a73ec25..5e0dd7d08e 100644
> --- a/refs/packed-backend.h
> +++ b/refs/packed-backend.h
> @@ -27,6 +27,12 @@ int packed_refs_lock(struct ref_store *ref_store, int flags, struct strbuf *err)
>  void packed_refs_unlock(struct ref_store *ref_store);
>  int packed_refs_is_locked(struct ref_store *ref_store);
>  
> +int packed_refs_delete_refs(struct ref_store *ref_store,
> +			    struct ref_transaction *transaction,
> +			    const char *msg,
> +			    struct string_list *refnames,
> +			    unsigned int flags);
> +
>  /*
>   * Return true if `transaction` really needs to be carried out against
>   * the specified packed_ref_store, or false if it can be skipped

This breaks "make hdr-check" (which is part of CI -- static-analysis).

----- >8 --------- >8 --------- >8 --------- >8 -----
From: Junio C Hamano <[email-masked]>
Date: Wed, 12 Jan 2022 16:24:13 -0800
Subject: [PATCH] fixup! refs: open-code deletion of packed refs

---
 refs/packed-backend.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/refs/packed-backend.h b/refs/packed-backend.h
index 5e0dd7d08e..a2cca5d9a3 100644
--- a/refs/packed-backend.h
+++ b/refs/packed-backend.h
@@ -3,6 +3,7 @@
 
 struct repository;
 struct ref_transaction;
+struct string_list;
 
 /*
  * Support for storing references in a `packed-refs` file.
-- 
2.35.0-rc0-185-gedd802a149