From: Junio C Hamano <gitster@pobox•com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
Cc: David Turner <dturner@twopensource•com>, git@vger•kernel.org
Subject: Re: [PATCH] log: add log.follow config option
Date: Fri, 03 Jul 2015 10:47:15 -0700 [thread overview]
Message-ID: <xmqqy4ix3zh8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqr3op676u.fsf@anie.imag.fr> (Matthieu Moy's message of "Fri, 03 Jul 2015 09:17:45 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr> writes:
> David Turner <dturner@twopensource•com> writes:
>
>> Twitter's history is almost completely linear, so it's useful for us.
>>
>> Since it looks like the patch won't be useful outside of our context,
>> I'll just rewrite it to check the pathspec count, and not upstream it
>> until follow becomes more general.
>
> As long as it's an opt-in and that the documentation states the
> limitations clearly enough, I think it makes sense to me to have this
> upstream.
Perhaps. But at least "log -- 1 2" and "log --" should not be broken
for those that set the configuration.
Unless you are counting these as also "limitations", that is.
prev parent reply other threads:[~2015-07-03 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 19:03 [PATCH] log: add log.follow config option David Turner
2015-07-01 21:16 ` Matthieu Moy
2015-07-01 21:19 ` Junio C Hamano
2015-07-02 18:43 ` David Turner
2015-07-03 7:17 ` Matthieu Moy
2015-07-03 17:47 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4ix3zh8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=dturner@twopensource$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox