From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: Jonathan Nieder <jrnieder@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH 0/5] Retry if fdopen() fails due to ENOMEM
Date: Thu, 05 Mar 2015 11:19:36 -0800 [thread overview]
Message-ID: <xmqqy4nb2qwn.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1425571669-22800-1-git-send-email-mhagger@alum.mit.edu> (Michael Haggerty's message of "Thu, 5 Mar 2015 17:07:44 +0100")
Michael Haggerty <mhagger@alum•mit.edu> writes:
> One likely reason for fdopen() to fail is the lack of memory for
> allocating a FILE structure. When that happens, try freeing some
> memory and calling fdopen() again in the hope that it will work the
> second time.
In codepaths where we are likely under memory pressure, the above
might help, but I have to wonder
(1) if update-server-info and daemon fall into that category; and
(2) if Git continues to work under such a memory pressure to
cause even fdopen() to fail.
In other words, I do not see a reason not to do this change, but I
am not sure how much it would help us in practice.
We call fopen() from a lot more places than we call fdopen(). Do we
want to do the same, or is there a good reason why this does not
matter to callers of fopen(), and if so why doesn't the same reason
apply to callers of fdopen()?
> Michael Haggerty (5):
> xfdopen(): if first attempt fails, free memory and try again
> fdopen_lock_file(): use fdopen_with_retry()
> copy_to_log(): use fdopen_with_retry()
> update_info_file(): use fdopen_with_retry()
> buffer_fdinit(): use fdopen_with_retry()
>
> daemon.c | 4 ++--
> git-compat-util.h | 11 +++++++++++
> lockfile.c | 2 +-
> server-info.c | 2 +-
> vcs-svn/line_buffer.c | 2 +-
> wrapper.c | 28 +++++++++++++++++++++++++---
> 6 files changed, 41 insertions(+), 8 deletions(-)
next prev parent reply other threads:[~2015-03-05 19:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 16:07 [PATCH 0/5] Retry if fdopen() fails due to ENOMEM Michael Haggerty
2015-03-05 16:07 ` [PATCH 1/5] xfdopen(): if first attempt fails, free memory and try again Michael Haggerty
2015-03-05 16:59 ` Stefan Beller
2015-03-05 19:06 ` Junio C Hamano
2015-03-05 16:07 ` [PATCH 2/5] fdopen_lock_file(): use fdopen_with_retry() Michael Haggerty
2015-03-05 16:07 ` [PATCH 3/5] copy_to_log(): " Michael Haggerty
2015-03-05 16:07 ` [PATCH 4/5] update_info_file(): " Michael Haggerty
2015-03-05 16:07 ` [PATCH 5/5] buffer_fdinit(): " Michael Haggerty
2015-03-05 19:19 ` Junio C Hamano [this message]
2015-03-10 11:42 ` [PATCH 0/5] Retry if fdopen() fails due to ENOMEM Michael Haggerty
2015-03-06 5:08 ` Torsten Bögershausen
2015-03-10 11:44 ` Michael Haggerty
2015-03-17 22:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4nb2qwn.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=mhagger@alum$(echo .)mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox