From: Junio C Hamano <gitster@pobox•com>
To: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
Cc: "Bernhard Reiter" <ockham@raz•or.at>,
"Torsten Bögershausen" <tboegi@web•de>,
git@vger•kernel.org
Subject: Re: [PATCH] git-imap-send: use libcurl for implementation
Date: Sun, 09 Nov 2014 09:45:04 -0800 [thread overview]
Message-ID: <xmqqy4rkb74v.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <545FA3FA.10308@ramsay1.demon.co.uk> (Ramsay Jones's message of "Sun, 09 Nov 2014 17:27:22 +0000")
Ramsay Jones <ramsay@ramsay1•demon.co.uk> writes:
>> In order to suppress a sparse warning about "using sizeof on a
>> function", we use the same solution used in commit 9371322a6
>> ("sparse: suppress some "using sizeof on a function" warnings",
>> 06-10-2013) which solved exactly this problem for the other commands
>> using libcurl.
>
> Although it doesn't hurt, I don't think this 'problem' deserves
> so many (or any) inches in the commit message. ;-)
Use smaller line pitch, then? ;-) I am sure myself 6 months down the
road as a "git show" reader of this patch would appreciate these
five lines when I scratch my head looking at the Makefile changes.
>> Signed-off-by: Bernhard Reiter <ockham@raz•or.at>
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
>
> Since I didn't actually review this patch, or make any significant
> contribution to the code (it's not even enough to be copyright-able!),
> then this 'Signed-off-by:' should not be included. At *most* you might
> want to put a 'Helped-by:' _prior_ to your sign-off.
Yes, that is the appropriate thing to do, I would think.
Thanks.
next prev parent reply other threads:[~2014-11-09 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 22:40 [PATCH] git-imap-send: use libcurl for implementation Bernhard Reiter
2014-08-27 17:20 ` Junio C Hamano
2014-10-12 15:22 ` Bernhard Reiter
2014-10-22 15:05 ` Fwd: " Bernhard Reiter
2014-10-22 17:47 ` Junio C Hamano
2014-10-29 18:41 ` Bernhard Reiter
2014-10-29 20:56 ` Junio C Hamano
2014-11-09 13:00 ` Torsten Bögershausen
2014-11-09 14:55 ` Bernhard Reiter
2014-11-09 17:27 ` Ramsay Jones
2014-11-09 17:45 ` Junio C Hamano [this message]
2014-11-10 17:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4rkb74v.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ockham@raz$(echo .)or.at \
--cc=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox