From: Junio C Hamano <gitster@pobox•com>
To: Harry Jeffery <harry@exec64•co.uk>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v3] pretty: add %D format specifier
Date: Tue, 16 Sep 2014 21:30:50 -0700 [thread overview]
Message-ID: <xmqqy4tizx51.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqegvb2yza.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Tue, 16 Sep 2014 11:37:29 -0700")
Junio C Hamano <gitster@pobox•com> writes:
>> +test_expect_success 'clean log decoration' '
>> + git log --no-walk --tags --pretty="%H %D" --decorate=full >actual &&
>> + cat <<EOF >expected &&
>> +$head1 tag: refs/tags/tag2
>> +$head2 tag: refs/tags/message-one
>> +$old_head1 tag: refs/tags/message-two
>> +EOF
> ...
> Hmph. I actually think the part that prepares the history makes
> sure that the output order of the commits is predictable by using
> test_commit and test_tick. I see existing tests at the end (which
> is a sign that they were added more recently than the rest of the
> test script, and can indicate a careless addition) already has
> "sort", but we shouldn't have to sort.
Actually --tags may feed the tips in unspecified order and --no-walk
ensures the commits will be shown in that unspecified order, so for
a test that runs "log --no-walk --tags", sorting is unavoidable.
prev parent reply other threads:[~2014-09-17 4:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 17:37 [PATCH v3] pretty: add %D format specifier Harry Jeffery
2014-09-16 18:37 ` Junio C Hamano
2014-09-17 4:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4tizx51.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=harry@exec64$(echo .)co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox