From: Junio C Hamano <gitster@pobox•com>
To: Heiko Voigt <hvoigt@hvoigt•net>
Cc: git@vger•kernel.org, Jens Lehmann <jens.lehmann@web•de>,
Jonathan Nieder <jrnieder@gmail•com>, Jeff King <peff@peff•net>,
"W. Trevor King" <wking@tremily•us>,
Eric Sunshine <sunshine@sunshineco•com>,
Karsten Blees <karsten.blees@gmail•com>
Subject: Re: [PATCH v2 3/4] use new config API for worktree configurations of submodules
Date: Tue, 08 Jul 2014 13:14:20 -0700 [thread overview]
Message-ID: <xmqqy4w38v6r.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140628100321.GD89729@book.hvoigt.net> (Heiko Voigt's message of "Sat, 28 Jun 2014 12:03:22 +0200")
Heiko Voigt <hvoigt@hvoigt•net> writes:
> diff --git a/builtin/checkout.c b/builtin/checkout.c
> index 07cf555..03ea20d 100644
> --- a/builtin/checkout.c
> +++ b/builtin/checkout.c
> @@ -18,6 +18,7 @@
> #include "xdiff-interface.h"
> #include "ll-merge.h"
> #include "resolve-undo.h"
> +#include "submodule-config.h"
> #include "submodule.h"
> #include "argv-array.h"
>
Hmph. What is this change about?
Nobody in checkout.c needs anything new, yet we add a new include?
> diff --git a/diff.c b/diff.c
> index f72769a..f692a3c 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -13,6 +13,7 @@
> #include "utf8.h"
> #include "userdiff.h"
> #include "sigchain.h"
> +#include "submodule-config.h"
> #include "submodule.h"
> #include "ll-merge.h"
> #include "string-list.h"
Likewise.
It is somewhat unclear to me what real change that improves the life
of end-users this series brings to us. The "test-submodule-config"
test program obviously is new but that does not really count until
we see real uses.
next prev parent reply other threads:[~2014-07-08 20:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 9:58 [PATCH v2 0/4] submodule config lookup API Heiko Voigt
2014-06-28 10:01 ` [PATCH v2 1/4] implement submodule config cache for lookup of submodule names Heiko Voigt
2014-06-28 10:02 ` [PATCH v2 2/4] extract functions for submodule config set and lookup Heiko Voigt
2014-06-28 10:03 ` [PATCH v2 3/4] use new config API for worktree configurations of submodules Heiko Voigt
2014-07-08 20:14 ` Junio C Hamano [this message]
2014-07-09 19:55 ` Heiko Voigt
2014-07-09 22:04 ` Junio C Hamano
2014-07-14 20:57 ` Heiko Voigt
2014-07-15 22:37 ` Junio C Hamano
2014-07-17 19:53 ` Heiko Voigt
2014-07-17 20:08 ` Junio C Hamano
2014-06-28 10:04 ` [PATCH v2 4/4] do not die on error of parsing fetchrecursesubmodules option Heiko Voigt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4w38v6r.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=hvoigt@hvoigt$(echo .)net \
--cc=jens.lehmann@web$(echo .)de \
--cc=jrnieder@gmail$(echo .)com \
--cc=karsten.blees@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
--cc=wking@tremily$(echo .)us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox