public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Sebastian Schuberth <sschuberth@gmail•com>,
	Johannes Sixt <j6t@kdbg•org>,
	thomas.braun@byte-physics•de, git@vger•kernel.org
Subject: Re: [PATCH] t5510: Do not use $(pwd) when fetching / pushing / pulling via rsync
Date: Wed, 19 Mar 2014 14:10:25 -0700	[thread overview]
Message-ID: <xmqqy50528u6.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1403192103300.14982@s15462909.onlinehome-server.info> (Johannes Schindelin's message of "Wed, 19 Mar 2014 21:03:57 +0100 (CET)")

Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:

> Hi Sebastian,
>
> On Wed, 19 Mar 2014, Sebastian Schuberth wrote:
>
>> On MINGW, "pwd" is defined as "pwd -W" in test-lib.sh. This usually is the
>> right thing, but the absolute Windows path with a colon confuses rsync. We
>> could use $PWD in this case to work around the issue, but in fact there is
>> no need to use an absolute path in the first place, so get rid of it.
>> 
>> This was discovered in the context of the mingwGitDevEnv project and only
>> did not surface before with msysgit because the latter does not ship
>> rsync.
>
> ACK
>
> Ciao,
> Dscho

Thanks.

     prev parent reply	other threads:[~2014-03-19 21:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 19:43 [PATCH] t5510: Do not use $(pwd) when fetching / pushing / pulling via rsync Sebastian Schuberth
2014-03-19 20:03 ` Johannes Schindelin
2014-03-19 21:10   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy50528u6.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=Johannes.Schindelin@gmx$(echo .)de \
    --cc=git@vger$(echo .)kernel.org \
    --cc=j6t@kdbg$(echo .)org \
    --cc=sschuberth@gmail$(echo .)com \
    --cc=thomas.braun@byte-physics$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox