From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH v2] tag: support --sort=<spec>
Date: Mon, 24 Feb 2014 08:39:51 -0800 [thread overview]
Message-ID: <xmqqy510bh2g.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140222080404.GB1576@sigill.intra.peff.net> (Jeff King's message of "Sat, 22 Feb 2014 03:04:04 -0500")
Jeff King <peff@peff•net> writes:
> On Sat, Feb 22, 2014 at 10:29:22AM +0700, Nguyễn Thái Ngọc Duy wrote:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail•com>
>> ---
>> The new prereq GNULINUX is an ugly workaround until people provide
>> strverscmp compat implementation. I hope that will happen soon as
>> strverscmp.c does not look very complex.
>
> Should GNULINUX be called HAVE_STRVERSCMP in the Makefile?
>
> Then this:
>
>> --- a/git-compat-util.h
>> +++ b/git-compat-util.h
>> @@ -721,4 +721,11 @@ void warn_on_inaccessible(const char *path);
>> /* Get the passwd entry for the UID of the current process. */
>> struct passwd *xgetpwuid_self(void);
>>
>> +#ifndef __GNU_LIBRARY__
>> +static inline int strverscmp(const char *s1, const char *s2)
>> +{
>> + die("strverscmp() not supported");
>> +}
>> +#endif
>
> becomes "#ifndef HAVE_STRVERSCMP", and this:
>
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index 1531c24..5e8c39a 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -771,6 +771,8 @@ case $(uname -s) in
>> ;;
>> esac
>>
>> +[ "$(uname -o)" = "GNU/Linux" ] && test_set_prereq GNULINUX
>> +
>
> can pick up the value from GIT-BUILD-OPTIONS as a prerequisite (see the
> way we handle NO_PERL for an example). Though if we can just grab the
> glibc version as a fallback, we can do away with that completely.
;-) I like that.
next prev parent reply other threads:[~2014-02-24 16:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 13:39 [PATCH] tag: support --sort=version Nguyễn Thái Ngọc Duy
2014-02-19 14:09 ` Jeff King
2014-02-19 14:19 ` Duy Nguyen
2014-02-20 20:43 ` Jeff King
2014-02-21 11:58 ` Duy Nguyen
2014-02-21 17:48 ` Junio C Hamano
2014-02-22 7:59 ` Jeff King
2014-02-22 9:07 ` Duy Nguyen
2014-02-19 18:43 ` Eric Sunshine
2014-02-22 3:29 ` [PATCH v2] tag: support --sort=<spec> Nguyễn Thái Ngọc Duy
2014-02-22 8:04 ` Jeff King
2014-02-24 16:39 ` Junio C Hamano [this message]
2014-02-24 23:30 ` Duy Nguyen
2014-02-24 23:33 ` Jeff King
2014-02-25 12:22 ` [PATCH v3] " Nguyễn Thái Ngọc Duy
2014-02-25 17:42 ` Junio C Hamano
2014-02-26 9:05 ` Jeff King
2014-02-26 11:03 ` Duy Nguyen
2014-02-26 11:08 ` Jeff King
2014-02-26 11:11 ` Duy Nguyen
2014-02-26 11:17 ` Jeff King
2014-02-26 11:31 ` Duy Nguyen
2014-02-27 12:56 ` [PATCH v4] " Nguyễn Thái Ngọc Duy
2014-02-27 13:11 ` Jeff King
2014-02-27 13:23 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy510bh2g.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox