From: Junio C Hamano <gitster@pobox•com>
To: git@vger•kernel.org
Cc: Keshav Kini <keshav.kini@gmail•com>,
Milton Soares Filho <milton.soares.filho@gmail•com>,
Adam Simpkins <simpkins@facebook•com>
Subject: Re: [RFH/PATCH] graph: give an extra gap after showing root commit
Date: Fri, 20 Dec 2013 14:03:17 -0800 [thread overview]
Message-ID: <xmqqy53fch96.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqbo0be0hc.fsf_-_@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Fri, 20 Dec 2013 12:22:39 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> Note that this still does not work very well for --boundary case
> (see the last test added to t6016).
> ...
> +test_expect_failure 'multi-root does not emit unnecessary post-root gap' '
> + git log --oneline --graph merge210~1...merge210~1^2~2 >actual &&
> + ! grep "^$" actual
> +'
Obviously, this needs to be
git log --oneline --graph --boundary merge210~1...merge210~1^2~2 >actual &&
for it to fail.
next prev parent reply other threads:[~2013-12-20 22:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 16:07 [PATCH] graph.c: visual difference on subsequent series Milton Soares Filho
2013-10-25 17:13 ` Junio C Hamano
2013-10-25 20:49 ` Milton Soares Filho
2013-10-26 2:37 ` Keshav Kini
2013-10-28 15:41 ` Junio C Hamano
2013-10-28 16:59 ` Keshav Kini
2013-10-28 17:18 ` Milton Soares Filho
2013-10-28 17:39 ` Junio C Hamano
2013-12-20 20:22 ` [RFH/PATCH] graph: give an extra gap after showing root commit Junio C Hamano
2013-12-20 22:03 ` Junio C Hamano [this message]
2014-01-03 20:16 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy53fch96.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=keshav.kini@gmail$(echo .)com \
--cc=milton.soares.filho@gmail$(echo .)com \
--cc=simpkins@facebook$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox