public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Josh Steadmon <steadmon@google•com>
Cc: Ghanshyam Thakkar <shyamthakkar001@gmail•com>,
	 git@vger•kernel.org, Jonathan Nieder <jrnieder@gmail•com>,
	 christian.couder@gmail•com,
	Phillip Wood <phillip.wood123@gmail•com>,
	 Christian Couder <chriscool@tuxfamily•org>,
	 Kaartic Sivaraam <kaartic.sivaraam@gmail•com>
Subject: Re: [GSoC][PATCH v2] t: migrate helper/test-oidmap.c to unit-tests/t-oidmap.c
Date: Mon, 01 Jul 2024 14:19:33 -0700	[thread overview]
Message-ID: <xmqqzfr0u7x6.fsf@gitster.g> (raw)
In-Reply-To: <hxld3ldxomitv6hjuxq7munhppzie2nm3eworng6jnhf3suikx@rh6cunbz4vcz> (Josh Steadmon's message of "Mon, 1 Jul 2024 13:32:30 -0700")

Josh Steadmon <steadmon@google•com> writes:

>> This version addresses Phillip's review about detecting duplicates in
>> oidmap when iterating over it and removing put_and_check_null() to move
>> the relevant code to setup() instead. And contains some grammer fixes
>> in the comment.
>
> IIUC this corrects all of the issues that Phillip noted in his earlier
> review, except for checking for duplicates, is that right?

There is an attempted duplicate checking during iteration; the test
data source key_val[] array is (ab)used to record the already seen
keys during the iteration, which would work but is a hacky and
unmaintainable way to do so.

Thanks for reviewing.

next prev parent reply	other threads:[~2024-07-01 21:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19 17:50 [GSoC][PATCH] t: migrate helper/test-oidmap.c to unit-tests/t-oidmap.c Ghanshyam Thakkar
2024-06-20  9:45 ` Jonathan Nieder
2024-06-25  1:35   ` Ghanshyam Thakkar
2024-06-25 10:14   ` Phillip Wood
2024-06-25 19:16     ` Ghanshyam Thakkar
2024-06-26  8:59       ` phillip.wood123
2024-06-28 12:20 ` [GSoC][PATCH v2] " Ghanshyam Thakkar
2024-07-01 20:32   ` Josh Steadmon
2024-07-01 21:19     ` Junio C Hamano [this message]
2024-07-01 21:14   ` Junio C Hamano
2024-07-01 22:20     ` Junio C Hamano
2024-07-02  3:48       ` Ghanshyam Thakkar
2024-07-02 15:17       ` Phillip Wood
2024-07-02 15:24   ` Phillip Wood
2024-07-02 16:25     ` Ghanshyam Thakkar
2024-07-02 18:55     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzfr0u7x6.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=chriscool@tuxfamily$(echo .)org \
    --cc=christian.couder@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jrnieder@gmail$(echo .)com \
    --cc=kaartic.sivaraam@gmail$(echo .)com \
    --cc=phillip.wood123@gmail$(echo .)com \
    --cc=shyamthakkar001@gmail$(echo .)com \
    --cc=steadmon@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox