public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: "Csókás Bence" <csokas.bence@prolan•hu>
Cc: <git@vger•kernel.org>
Subject: Re: [PATCH resend] git-send-email: Use sanitized address when reading mbox body
Date: Wed, 26 Jun 2024 06:33:24 -0700	[thread overview]
Message-ID: <xmqqzfr77rrv.fsf@gitster.g> (raw)
In-Reply-To: <202fc42e-c5be-4a4b-a135-302d8fbf6b2a@prolan.hu> ("Csókás Bence"'s message of "Wed, 26 Jun 2024 10:58:03 +0200")

Csókás Bence <csokas.bence@prolan•hu> writes:

>> In any case, if we were to move forward with this topic (whether
>> "send to corrected $sc instead" or "$c is suspicious, do not add it
>> to $cc" is picked as the direction), the motivation behind the
>> design decision to treat the address taken from a trailer line
>> differently needs to be explained better, I think. [...]
>> Your proposed commit log message is the place to help them.
>
> Okay. So in short, I should add justification for trusting mbox
> headers and not the message body, correct?

We want these to be explained for future readers:

 (1) we stuff the sanitized address to @cc in this particular place,
     but we still let all other places copy the original taken from
     the message to @to or @cc (as in the original code).

 (2) the reason behind the above difference is because we trust less
     about the "address looking" strings that appear on the trailer
     lines.

So, not just (2), but in order for the readers to understand why
they should care about (2), they need to be told (1) as well.

Thanks.

     prev parent reply	other threads:[~2024-06-26 13:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  9:27 [PATCH resend] git-send-email: Use sanitized address when reading mbox body Csókás, Bence
2024-06-21 17:27 ` Junio C Hamano
2024-06-24  7:37   ` Csókás Bence
2024-06-24 15:50     ` Junio C Hamano
2024-06-26  8:58       ` Csókás Bence
2024-06-26 13:33         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzfr77rrv.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=csokas.bence@prolan$(echo .)hu \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox