public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Diomidis Spinellis <dds@aueb•gr>
Cc: git@vger•kernel.org, Eric Sunshine <sunshine@sunshineco•com>,
	avarab@gmail•com
Subject: Re: [PATCH v4] grep: fix multibyte regex handling under macOS
Date: Tue, 13 Sep 2022 10:32:06 -0700	[thread overview]
Message-ID: <xmqqzgf389k9.fsf@gitster.g> (raw)
In-Reply-To: <20220826085815.2771102-1-dds@aueb.gr> (Diomidis Spinellis's message of "Fri, 26 Aug 2022 11:58:15 +0300")

Diomidis Spinellis <dds@aueb•gr> writes:

> - Fold test script into t7810-grep.sh
> - Simplify the test prerequisite evaluation

The tests certainly look better, and as v3, the build procedure
sounds OK.

> diff --git a/common-main.c b/common-main.c
> index c531372f3f..0a22861f1c 100644
> --- a/common-main.c
> +++ b/common-main.c
> @@ -40,6 +40,7 @@ int main(int argc, const char **argv)
>  
>  	git_resolve_executable_dir(argv[0]);
>  
> +	setlocale(LC_CTYPE, "");
>  	git_setup_gettext();
>  
>  	initialize_the_repository();
> ...
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 58d7708296..c6fa3c7469 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -212,6 +212,7 @@
>  #endif
>  #include <errno.h>
>  #include <limits.h>
> +#include <locale.h>
>  #ifdef NEEDS_SYS_PARAM_H
>  #include <sys/param.h>
>  #endif

I'll let others more familiar with the locale support to comment on
these changes.  We are unconditionally including <locale.h> now;
platforms that lack <locale.h> could set NO_GETTEXT to work it
around before this change, but that will no longer work.

I do not know if thta is a practical downside to anybody, but it
could be a problem.

Perhaps cook this in 'next' and see if anybody screams?

Thanks.

next prev parent reply	other threads:[~2022-09-13 18:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <pull.1313.v2.git.git.1661289990205.gitgitgadget () gmail ! com>
2022-08-25  8:20 ` [PATCH v3] grep: fix multibyte regex handling under macOS Diomidis Spinellis
2022-08-26  0:20   ` Junio C Hamano
2022-08-26  8:58 ` [PATCH v4] " Diomidis Spinellis
2022-09-13 17:32   ` Junio C Hamano [this message]
2022-09-13 18:09     ` Diomidis Spinellis
2022-09-13 20:41       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzgf389k9.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=avarab@gmail$(echo .)com \
    --cc=dds@aueb$(echo .)gr \
    --cc=git@vger$(echo .)kernel.org \
    --cc=sunshine@sunshineco$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox