Subject: Re: [PATCH v3 00/13] tests: add and use a "test_hook" wrapper + hook fixes

From: Junio C Hamano <[email-masked]>
Date: Thu, 17 Mar 2022 14:40:15 -0700

Ævar Arnfjörð Bjarmason <[email-masked]> writes:

> Pending a re-roll this fix-up for 11/13 should fix it.
>
> I do test with /bin/bash before submitting to catch exactly this class
> of issue, but for reasons I haven't looked into this one is odd in not
> failing with --verbose-log, but I see the OSX CI (which I didn't wait
> for) fails on the same issue. Sorry.

Hmph, my integration run failed right away.  I use bash and dash on
alternate days, and you got lucky today ;-)

> diff --git a/t/t5543-atomic-push.sh b/t/t5543-atomic-push.sh
> index 90676365471..70431122a40 100755
> --- a/t/t5543-atomic-push.sh
> +++ b/t/t5543-atomic-push.sh
> @@ -162,13 +162,10 @@ test_expect_success 'atomic push obeys update hook preventing a branch to be pus
>  		test_commit two &&
>  		git push --mirror up
>  	) &&
> -	(
> -		cd upstream &&
> -		test_hook update <<-\EOF
> -			# only allow update to main from now on
> -			test "$1" = "refs/heads/main"
> -		EOF
> -	) &&
> +	test_hook -C upstream update <<-\EOF &&
> +	# only allow update to main from now on
> +	test "$1" = "refs/heads/main"
> +	EOF

OK.

>  	(
>  		cd workbench &&
>  		git checkout main &&