Subject: Re: [PATCH] send-email: add test for Linux's get_maintainer.pl

From: Junio C Hamano <[email-masked]>
Date: Fri, 05 Jan 2018 12:16:57 -0800

Matthieu Moy <[email-masked]> writes:

> Alex Bennée <[email-masked]> writes:
>
>> I think you need to apply Eric's suggestions from:
>>
>>   From: Eric Sunshine <[email-masked]>
>>   Date: Sat, 18 Nov 2017 21:54:46 -0500
>>   Message-ID: <[email-masked]>
>
> Indeed. I'm squashing this into the patch:
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index f126177..d13d8c3 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -173,8 +173,7 @@ test_expect_success $PREREQ 'cc trailer with various syntax' '
>  '
>  
>  test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer' "
> -	cat >expected-cc-script.sh <<-EOF &&
> -	#!/bin/sh
> +	write_script expected-cc-script.sh <<-EOF &&
>  	echo 'One Person <[email-masked]> (supporter:THIS (FOO/bar))'
>  	echo 'Two Person <[email-masked]> (maintainer:THIS THING)'
>  	echo 'Third List <[email-masked]> (moderated list:THIS THING (FOO/bar))'

Please do not forget to lose "chmod +x", which becomes unneeded when
you use write_script.

> @@ -186,7 +185,6 @@ test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer'
>  "
>  
>  test_expect_success $PREREQ 'cc trailer with get_maintainer.pl output' '
> -	test_commit cc-trailer-getmaint &&
>  	clean_fake_sendmail &&
>  	git send-email -1 --to=[email-masked] \
>  		--cc-cmd="./expected-cc-script.sh" \