From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Martin Koegler <martin.koegler@chello•at>, git@vger•kernel.org
Subject: Re: [PATCH] Fix delta integer overflows
Date: Mon, 07 Aug 2017 16:02:23 -0700 [thread overview]
Message-ID: <xmqqzibbm16o.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqwp6fnjpg.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 07 Aug 2017 14:36:59 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> This is not about where the bar is set. It is about expectation....
After having thought about this a bit more, I think in the message I
am responding to I mischaracterised the aspect of a patch that
influences the "expectation". It is much less about who the
contributor is but more about what the patch does.
If the patch in question were from a more experienced contributor
(like you or Peff), my internal reaction would have been "gee, the
submitter should have known better that a more complete fix should
involve a larger integral type, not stopping at matching the largest
type that happens to be used in the interface without updating the
interface".
But I still would have said that the patch is an improvement--as it
indeed is; it does not make things worse anywhere and brings in a
more consistency. And I still would have mentioned the same "in the
longer term, we would want to use size_t or uintmax_t here, not just
ulong".
The only thing I would have done differently if the submission were
by a more experienced contributor is that I probably would have
added "yes this may be an improvement, but I expected you should
know better to at least mention the longer term direction to use
size_t or uintmax_t in the log message, even if you didn't
immediately extend this patch into a more complete series".
That one is a difference of expectation between an occasional
contributor and an experienced one.
next prev parent reply other threads:[~2017-08-07 23:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 18:10 [PATCH] Fix delta integer overflows Martin Koegler
2017-08-07 18:36 ` Junio C Hamano
2017-08-07 19:39 ` Johannes Schindelin
2017-08-07 19:48 ` Junio C Hamano
2017-08-07 21:10 ` Johannes Schindelin
2017-08-07 21:36 ` Junio C Hamano
2017-08-07 23:02 ` Junio C Hamano [this message]
2017-08-08 6:20 ` Martin Koegler
2017-08-08 11:38 ` Johannes Schindelin
2017-08-08 1:44 ` Junio C Hamano
2017-08-08 6:25 ` Martin Koegler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzibbm16o.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=martin.koegler@chello$(echo .)at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox