public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: bmwill@google•com, git@vger•kernel.org, jacob.keller@gmail•com
Subject: Re: [PATCHv3 3/3] submodule-config: clarify parsing of null_sha1 element
Date: Mon, 21 Nov 2016 19:42:28 -0800	[thread overview]
Message-ID: <xmqqziksfae3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161122013550.1800-4-sbeller@google.com> (Stefan Beller's message of "Mon, 21 Nov 2016 17:35:50 -0800")

Stefan Beller <sbeller@google•com> writes:

> +Whenever a submodule configuration is parsed in `parse_submodule_config_option`
> +via e.g. `gitmodules_config()`, it will be overwrite the null_sha1 entry.

It will overwrite?  It will be overwritten?  I guess it is the latter?

> +So in the normal case, when HEAD:.gitmodules is parsed first and then overlayed
> +with the repository configuration, the null_sha1 entry contains the local
> +configuration of a submodule (e.g. consolidated values from local git
>  configuration and the .gitmodules file in the worktree).
>  
>  For an example usage see test-submodule-config.c.

  reply	other threads:[~2016-11-22  3:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22  1:35 [PATCHv3 0/3] submodule-config: clarify/cleanup docs and header Stefan Beller
2016-11-22  1:35 ` [PATCHv3 1/3] submodule config: inline config_from_{name, path} Stefan Beller
2016-11-22  1:35 ` [PATCHv3 2/3] submodule-config: rename commit_sha1 to commit_or_tree Stefan Beller
2016-11-22  1:35 ` [PATCHv3 3/3] submodule-config: clarify parsing of null_sha1 element Stefan Beller
2016-11-22  3:42   ` Junio C Hamano [this message]
2016-11-22 18:36     ` Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqziksfae3.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=bmwill@google$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jacob.keller@gmail$(echo .)com \
    --cc=sbeller@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox