From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 5/5] pack-objects: walk tag chains for --include-tag
Date: Wed, 07 Sep 2016 11:49:28 -0700 [thread overview]
Message-ID: <xmqqzinjlf47.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160905215939.hriu6ev3m332qhp6@sigill.intra.peff.net> (Jeff King's message of "Mon, 5 Sep 2016 17:59:39 -0400")
Jeff King <peff@peff•net> writes:
> As explained further in the commit message, "fetch" is robust to this,
> because it does a real connectivity check and follow-on fetch before
> writing anything it thinks it got via include-tag. So perhaps one could
> argue that pack-objects is correct; include-tag is best-effort, and it
> is the client's job to make sure it has everything it needs. And that
> would mean the bug is in git-clone, which should be doing the
> connectivity check and follow-on fetch.
I think that is probably a more technically correct interpretation
of the history.
I think upgrading "best-effort" to "guarantee" like you did is a
right approach nevertheless. I think the "best-effort" we initially
did was merely us being lazy.
next prev parent reply other threads:[~2016-09-07 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 21:51 [PATCH 0/5] handle tag recursion in pack-objects --include-tag Jeff King
2016-09-05 21:52 ` [PATCH 1/5] t5305: move cleanup into test block Jeff King
2016-09-05 21:52 ` [PATCH 2/5] t5305: drop "dry-run" of unpack-objects Jeff King
2016-09-05 21:52 ` [PATCH 3/5] t5305: use "git -C" Jeff King
2016-09-05 21:52 ` [PATCH 4/5] t5305: simplify packname handling Jeff King
2016-09-05 21:52 ` [PATCH 5/5] pack-objects: walk tag chains for --include-tag Jeff King
2016-09-05 21:59 ` Jeff King
2016-09-07 18:49 ` Junio C Hamano [this message]
2016-09-07 19:45 ` Jeff King
2016-09-05 21:54 ` [PATCH 0/5] handle tag recursion in pack-objects --include-tag Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzinjlf47.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox