From: Junio C Hamano <gitster@pobox•com>
To: Michael J Gruber <git@drmicha•warpmail.net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] tests: rename work-tree tests to *work-tree*
Date: Mon, 22 Feb 2016 09:57:33 -0800 [thread overview]
Message-ID: <xmqqzius7hma.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <56CAE460.8010405@drmicha.warpmail.net> (Michael J. Gruber's message of "Mon, 22 Feb 2016 11:35:12 +0100")
Michael J Gruber <git@drmicha•warpmail.net> writes:
>> That is rather unfortunate. Most of them predate the "worktree"
>> subcommand, I think, and having to rename them merely because a
>> subcommand with a confusing name appeared sound somewhat backwards.
>
> The question is: What ist the way forward?
Probably many. Take this as-is is one, rename newer ones that are
about worktree subcommand to "s/worktree/worktree-cmd/" would be
another.
> I was looking for a proper place for a "git worktree" test and got
> confused by the status quo. My suggestion is one way to help that
> confusion, but I'd be happy to learn other ways. "grep" is an answer, too.
>
> Maybe it's also time to admit that the numbering and naming scheme in t/
> don't scale and that we should rather support other means of navigating
> t/, such as standardizing a comment boiler plate in each test or such.
Yeah, test_description at the beginning of each test may have been a
well meaning attempt, but it is not helping us very much.
> In fact, giving up on the numbering scheme would allow to regroup tests
> more easily because there would be no room constraint any more (within a
> fixed finite set of numbers).
I tend to agree that may be an easier way forward in the longer
term.
Thanks.
prev parent reply other threads:[~2016-02-22 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 16:18 [PATCH] tests: rename work-tree tests to *work-tree* Michael J Gruber
2016-02-20 21:42 ` Junio C Hamano
2016-02-22 10:35 ` Michael J Gruber
2016-02-22 17:57 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzius7hma.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox