public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Luke Diamand <luke@diamand•org>
Cc: Etienne Girard <etienne.g.girard@gmail•com>,
	Git Users <git@vger•kernel.org>, Pete Wyckoff <pw@padd•com>,
	Lars Schneider <larsxschneider@gmail•com>
Subject: Re: [PATCH] git-p4: Handle p4 submit failure
Date: Fri, 30 Oct 2015 13:23:42 -0700	[thread overview]
Message-ID: <xmqqziz0jeb5.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <5633CABA.1000003@diamand.org> (Luke Diamand's message of "Fri, 30 Oct 2015 19:53:30 +0000")

Luke Diamand <luke@diamand•org> writes:

> On 30/10/15 17:57, Junio C Hamano wrote:
>> Etienne Girard <etienne.g.girard@gmail•com> writes:
>>
>>> Yes, however if `p4 submit` fails the corresponding "Command failed"
>>> error message is displayed, and the p4 error message itself is
>>> displayed if any.
>>> Tthe script will also terminate successfully if self.edit_template
>>> returns false but it will exit with error code 1 if p4 submit fails.
>>>
>>> So the user will get "Command failed: [...]" followed by "Submission
>>> cancelled, undoing p4 changes", to let him know that the script failed
>>> because of p4 and that nothing was submitted.
>>
>> OK, then it sounds like all I have to do is to update the log
>> message with the "How about this" version and correct the authorship
>> to use your murex address, and then wait for reviews from real "git
>> p4" reviewers.
>>
>
> Looks good to me. Nice use of try...finally.
>
> One very small thing - test t9807-git-p4-submit.sh is now failing with
> this change.
>
> That's because it tries to delete one of the files it created, but you
> are now deleting it already! Could you just update that please?

I'll ask Etienne include that change in a reroll, as my environment
is not equipped to run any p4 tests.

Thanks.

     prev parent reply	other threads:[~2015-10-30 20:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 13:12 [PATCH] git-p4: Handle p4 submit failure Etienne Girard
2015-10-30 16:44 ` Junio C Hamano
2015-10-30 17:33   ` Etienne Girard
2015-10-30 17:57     ` Junio C Hamano
2015-10-30 19:53       ` Luke Diamand
2015-10-30 20:23         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqziz0jeb5.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=etienne.g.girard@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=larsxschneider@gmail$(echo .)com \
    --cc=luke@diamand$(echo .)org \
    --cc=pw@padd$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox