From: Junio C Hamano <gitster@pobox•com>
To: Jan-Philip Gehrcke <jgehrcke@googlemail•com>
Cc: git@vger•kernel.org
Subject: Re: Should the --encoding argument to log/show commands make any guarantees about their output?
Date: Wed, 17 Jun 2015 09:42:17 -0700 [thread overview]
Message-ID: <xmqqzj3y2snq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <557E91D2.3000908@googlemail.com> (Jan-Philip Gehrcke's message of "Mon, 15 Jun 2015 10:50:26 +0200")
Jan-Philip Gehrcke <jgehrcke@googlemail•com> writes:
> I was surprised to see that the output of
>
> git log --encoding=utf-8 "--format=format:%b"
>
> can contain byte sequences that are invalid in UTF-8. Note: I am using
> git 2.1.4 and the %b format specifier represents the commit message
> body.
Yeah, if the original was bad and cannot be sanely expressed in
UTF-8, you have two options. You can show the contents as raw bytes
recorded in the object with a warning so that the user can use it as
such (e.g. perhaps the original was indeed an iso8859-2 but was
incorrectly marked as UTF-8, or something like that, and a human
that is more intelligent than a tool _could_ guess and attempt to
recover). Or you can error out and refuse to produce output.
We deliberately made a design choice to take the former option.
next prev parent reply other threads:[~2015-06-17 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 8:50 Should the --encoding argument to log/show commands make any guarantees about their output? Jan-Philip Gehrcke
2015-06-15 16:21 ` Torsten Bögershausen
2015-06-16 9:38 ` Jan-Philip Gehrcke
2015-06-16 20:04 ` Torsten Bögershausen
2015-06-17 16:42 ` Junio C Hamano [this message]
2015-06-17 17:07 ` Jan-Philip Gehrcke
2015-06-17 18:46 ` Jeff King
2015-06-17 20:02 ` Junio C Hamano
2015-06-17 19:55 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzj3y2snq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jgehrcke@googlemail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox